Do not treat every channel reply as approval success - #18
Open
padmanabh275 wants to merge 1 commit into
Open
padmanabh275 wants to merge 1 commit into
padmanabh275 wants to merge 1 commit into
Conversation
Owner
Session 16 — graded ✅Score: +100. Every channel reply was treated as approval success, so an unrelated message could carry a run past a human gate. Exactly the failure Part 1 asks the assistant to prove it does not have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_approvalparked withChoices: yes, no, any later message in the same channel thread calledcomplete_waitingwithsuccess=True.noand unrelated text both authorised the gated action.success=False. Channel HITL did not.no/reject/deny/cancelfail the gate. Unmatched or blank text leaves the wait handle in place so the message is a new request. Emptychoicesstill accepts a non-empty free-text answer.Test plan
test_a_no_does_not_succeed_a_waiting_channel_approvalfailed before (succeededvsfailed) and passes after.test_unrelated_text_does_not_consume_a_waiting_channel_approvalfailed before (wait consumed) and passes after.test_a_reply_in_the_same_channel_thread_resumes_a_waiting_approvalstill passes foryes.pytest tests/test_channel_connections.py: 9 passed.No
.env, tokens, real messages, or API keys in this diff.