Repository navigation
backport: v0.26 bitcoin#28168 - #74
Closed
DCG-Claude wants to merge 1 commit into
Closed
DCG-Claude wants to merge 1 commit into
DCG-Claude wants to merge 1 commit into
Conversation
|
This pull request has conflicts, please rebase. |
This was referenced Sep 24, 2026
Collaborator
Author
|
tracker#3148 closed by a human |
…from univalue fa940f4 Remove unused raw-pointer read helper from univalue (MarcoFalke) Pull request description: The helpers are unused outside of tests and redundant with the existing `bool read(std::string_view raw);`. Fix both issues by removing them. Also, simplify the tests code by removing a `std::string` constructor where possible. ACKs for top commit: stickies-v: utACK fa940f4 TheCharlatan: tACK fa940f4 Tree-SHA512: 60c154c1046f01551335af79bf820a6104844f63e89977271b4336b3cd06ac3bab1379e18b7bc61d12bef7446029e91c16541ddecf9e88bc8bc897fc1f6ee2c8 Dash adaptations: - src/test/script_tests.cpp: kept Dash's side (no witness comment block, no taproot/asset tests); applied only the two read_json(json_tests::script_tests) simplifications in script_build and script_json_test - src/test/evo_trivialvalidation.cpp: Dash-only call sites built std::string(json_tests::trivially_{valid,invalid}, ... + sizeof(...)); json_tests symbols are now std::string (Makefile.test.include change), so rewritten to `const std::string& json{json_tests::...}` - src/test/governance_validators_tests.cpp: Dash-only read_json(std::string(json_tests::proposals_{valid,invalid}, ... sizeof ...)) rewritten to read_json(json_tests::proposals_{valid,invalid}) to match the new generated std::string type - src/wallet/test/bip39_tests.cpp: Dash-only read_json(std::string(json_tests::bip39_vectors, ... sizeof ...)) rewritten to read_json(json_tests::bip39_vectors) for the same reason - build_msvc/test_bitcoin/test_bitcoin.vcxproj: modify/delete conflict resolved by keeping the deletion; Dash has no build_msvc/ tree (the old MSVC build system was removed), and Dash has no other MSVC project that generates json headers Not applicable to Dash (intentionally omitted): - build_msvc/test_bitcoin/test_bitcoin.vcxproj: Dash's tree contains no build_msvc/ at all (MSVC build system removed); the equivalent generator change (json.h -> std::string) is applied in Dash's only generator, src/Makefile.test.include - src/test/script_standard_tests.cpp: hunk edits bip341_spk_test_vectors (TaprootBuilder test); Dash has no taproot and neither that test nor bip341_wallet_vectors.json exists in Dash - src/test/script_tests.cpp: the bip341_keypath_test_vectors hunk edits a taproot sighash test Dash does not have (no bip341_wallet_vectors.json); the other two script_tests.cpp hunks are applied
DCG-Claude
force-pushed
the
backport-0.26-b031-src-wallet
branch
from
October 18, 2026 17:12
dad37c6 to
efaa387
Compare
Collaborator
Author
|
Branch rewritten at
🤖 backportsys, on behalf of the Dash backport pipeline. |
Collaborator
Author
|
folded into backport-0.26-b202-misc: its commits ship there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Bitcoin Core v0.26 backports, batch
backport-0.26-b031-src-wallet.efaa387959Skipped in this batch:
Provenance
Each commit passed: cherry-pick (adapted by an Opus lane only where conflicts existed), build, touched tests, a mechanical diff-of-diffs check (every upstream hunk landed; no added line without an upstream counterpart), and an independent Opus verification lane where anything was adapted. Gate rows and lane artifacts are in the backportsys DB.