Repository navigation
Document native Windows BWA-MEM2 selection - #164
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the Windows BWA-MEM2 documentation and metadata-only test changes.
No open issues 🎉
What changed in this PR
This PR documents existing native Windows BWA-MEM2 support in automatic short-read aligner selection and reduces the cost of metadata-only tests. It does not change runtime alignment behavior.
Changes:
- Adds Windows to the documented platforms supporting automatic BWA-MEM2 selection.
- Explains Windows index preparation, memory requirements, and fallback to BWA.
- Uses a tiny FASTA fixture while retaining simulated reference lengths in
.faimetadata.
| File | Description |
|---|---|
tests/test_bwa_mem2.py |
Avoids writing large dummy sequences for metadata-only tests. |
README.md |
Includes Windows in the BWA-MEM2 platform documentation. |
docs/windows.md |
Documents automatic selection, index preparation, and memory considerations. |
Review effort: Balanced
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that the existing automatic short-read aligner selection also uses native BWA-MEM2 on Windows when its reference index is present and fits in memory. The Windows guide now shows how to prepare the index and explains the BWA fallback for smaller-memory machines.
Keep the BWA-MEM2 metadata fixtures small: the memory checks use lengths from the
.fai, so the tests can model a human reference without writing gigabytes of dummy sequence. The separate real alignment test still creates and aligns actual sequence.Validation:
--aligner autopipeline produced decoded alignment records identical to Linux on matched real chromosome-region inputs.