Skip to content

Document native Windows BWA-MEM2 selection - #164

Merged
theontho merged 1 commit into
mainfrom
docs/windows-mem2-auto
Oct 26, 2026
Merged

theontho merged 1 commit into
mainfrom
docs/windows-mem2-auto

Conversation

@theontho

Copy link
Copy Markdown
Owner

Document that the existing automatic short-read aligner selection also uses native BWA-MEM2 on Windows when its reference index is present and fits in memory. The Windows guide now shows how to prepare the index and explains the BWA fallback for smaller-memory machines.

Keep the BWA-MEM2 metadata fixtures small: the memory checks use lengths from the .fai, so the tests can model a human reference without writing gigabytes of dummy sequence. The separate real alignment test still creates and aligns actual sequence.

Validation:

  • Installed native Windows BWA-MEM2 and the CLI --aligner auto pipeline produced decoded alignment records identical to Linux on matched real chromosome-region inputs.
  • BWA-MEM2 tests: 12 passed; runtime fell from 52.31s to 3.26s.
  • Ordinary local suite: 1,880 passed, 30 skipped, 87 deselected.
  • Ruff, formatting, pre-commit, source mypy, and diff checks passed.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 08:01
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the Windows BWA-MEM2 documentation and metadata-only test changes.

No open issues 🎉

What changed in this PR

This PR documents existing native Windows BWA-MEM2 support in automatic short-read aligner selection and reduces the cost of metadata-only tests. It does not change runtime alignment behavior.

Changes:

  • Adds Windows to the documented platforms supporting automatic BWA-MEM2 selection.
  • Explains Windows index preparation, memory requirements, and fallback to BWA.
  • Uses a tiny FASTA fixture while retaining simulated reference lengths in .fai metadata.
File Description
tests/​test_bwa_mem2.py Avoids writing large dummy sequences for metadata-only tests.
README.md Includes Windows in the BWA-MEM2 platform documentation.
docs/​windows.md Documents automatic selection, index preparation, and memory considerations.

Review effort: Balanced

@theontho
theontho merged commit 5bb97a1 into main Oct 26, 2026
17 checks passed
@theontho
theontho deleted the docs/windows-mem2-auto branch October 26, 2026 08:20
@theontho theontho mentioned this pull request Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants