Repository navigation
feature(grenade-throw-force): add callback for actor grenade throw force - #782
Merged
themrdemonized merged 1 commit intoOct 24, 2026
Merged
Conversation
- Added callback for actor grenade throw force - Improve code paths regarding default throw force : regualar throw force was in CInventoryOwner::missile_throw_force (value driven by owner), but default throw force was inline in CMissile::Throw; - Removed goofy vibe coded comments in callbacks_gameobject.script;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
Little PR to add a new
actor_on_missile_throw_forcecallback, which, as the name suggests, allows to change the throw force of actor-thrown grenades.I moved some code around because the code paths were weird. Regular throw force was in
CInventoryOwner::missile_throw_force(value driven by owner), but default throw force (value driven by the missile itself) was inline inCMissile::Throw.I defined
CMissileas an external class inInventoryOwner.hinstead of including theMissile.cppfile, as to not repeat the same mistake as in #635...I took the liberty to remove parts of vibe coded code comments in
callbacks_gameobject.script, that describe one very specific use case of some callbacks (use npc:rank() to scale shit by rank), tell tale of LLMs working on a task and bleeding its context in code comments.That's all, thanks for maintaining this engine still in this sea of ai slop PRs 🙏