Repository navigation
Conversation
Contributor
|
this looks halfway to hash map. did you try replacing vector with hashmap? |
Author
|
Yeah that's faster thanks (52ms), just switched to |
Owner
|
Please retarget this change to MT branch only for this reasons:
I'll test it on MT branch later when your new PR lands Closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smem_containeris kept in sorted order, so building it with N items becomes O(N^2). This splits that array into 1024 buckets so we square a smaller number.Total animation load time drops from 386ms to 78ms for a Cordon save on an i9-14900K.
If this looks good I'll do a PR for MT as well.