Repository navigation
fix(ui): draw main menu modal dialogs outside the shniaga pp pass - #762
Merged
Merged
Conversation
Contributor
|
No description nor showcase? 🥺 |
Contributor
Author
|
yeah, commit name is more or less self explanatory (if you know what shniaga is) |
| modal->Draw(); | ||
| } | ||
|
|
||
| UI().RenderFont(); |
Contributor
There was a problem hiding this comment.
We start to call those if OnRenderPPUI_query() == true, is this expected?
Contributor
Author
There was a problem hiding this comment.
yes. they are safe to call regardless of that check. and now both non-PP case and shniaga(PP) case draw modal dialog separately here and both need those two calls because of this
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.