Repository navigation
Feat/issue 298/preserve context - #326
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
RunTurn can panic on nil inputs and can commit an assistant message even if the chat implementation returns a non-assistant role, potentially diverging session history from the returned response.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Implements a small orchestration boundary for multi-turn chat by introducing a turn-level helper that constructs outbound history and commits messages to the session only on success, aligning with Issue #298’s “preserve context across turns” and “no fabricated assistant responses on failure” requirements.
Changes:
- Replaces ad-hoc prompt/session mutation in the CLI path with
conversation.RunTurn. - Adds
conversation.ChatFuncandconversation.RunTurnto centralize turn orchestration and commit semantics. - Adds unit tests asserting correct outbound message ordering across two turns and ensuring failures/cancellation don’t mutate session history.
File summaries
| File | Description |
|---|---|
| main.go | Uses conversation.RunTurn and shared conversation.ChatFunc instead of mutating session directly. |
| internal/conversation/turn.go | Introduces RunTurn orchestration helper that builds outbound history and commits user+assistant on success. |
| internal/conversation/turn_test.go | Adds multi-turn and failure/cancellation tests for outbound message sequence and session immutability on errors. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3
to
+27
| import ( | ||
| "context" | ||
| "fmt" | ||
| ) | ||
|
|
||
| // ChatFunc requests one assistant response for an ordered message history. | ||
| type ChatFunc func(context.Context, string, []Message) (Message, error) | ||
|
|
||
| // RunTurn sends a user prompt with the session history and commits the | ||
| // user-assistant exchange only when chat succeeds. Any returned error leaves | ||
| // the session unchanged. | ||
| func RunTurn(ctx context.Context, session *Session, model string, prompt string, chat ChatFunc) (Message, error) { | ||
| messages := session.Messages() | ||
| messages = append(messages, Message{Role: RoleUser, Content: prompt}) | ||
|
|
||
| response, err := chat(ctx, model, messages) | ||
| if err != nil { | ||
| return Message{}, fmt.Errorf("run conversation turn: %w", err) | ||
| } | ||
|
|
||
| session.AppendUser(prompt) | ||
| session.AppendAssistant(response.Content) | ||
|
|
||
| return response, nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #298