Repository navigation
chore: restore pre-commit validation - #324
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The newly added config files contain trailing whitespace that will immediately trigger the configured trailing-whitespace hook and cause pre-commit runs to fail until corrected.
Pull request overview
Restores local developer validation by introducing a pre-commit configuration for Go formatting/build/test/lint and adding a markdownlint configuration to standardize Markdown checks.
Changes:
- Adds
.pre-commit-config.yamlwith local Go hooks plus markdownlint, codespell, and common pre-commit hygiene checks. - Adds
.markdownlint.yamlto enable markdownlint defaults while disabling MD013 (line length).
File summaries
| File | Description |
|---|---|
| .pre-commit-config.yaml | Introduces pre-commit hooks for Go + general repo hygiene checks. |
| .markdownlint.yaml | Configures markdownlint defaults and disables MD013. |
Review details
Suppressed comments (2)
.pre-commit-config.yaml:77
- There is trailing whitespace on the final line (line 77). With the
trailing-whitespacepre-commit hook enabled in this same config, this file will be auto-modified and cause the hook run to fail until re-staged.
- id: check-case-conflict
.markdownlint.yaml:4
- Line 4 contains trailing whitespace (a blank line with spaces). This will be caught by the
trailing-whitespacepre-commit hook and cause the hook run to fail until the whitespace is removed.
MD013: false
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.