Repository navigation
Consolidate CI range and validation policy ownership - #150
Conversation
Initial review dispositionsRAS review
The precise accepted invariant for C-005 is that the named divergent-case fixture discriminates the docs entrypoint's merge-base comparison. Its owner is that fixture arrangement in Validation after the fixture change: all 20 cases pass against both the pre-extraction scripts at |
Verification receiptVerification of review C-005 is resolved. The verifier reproduced all 20 passing cases and confirmed that an endpoint-based docs comparison fails the revised divergent case (status 2 instead of 0). No new observations were reported. C-001 through C-004 remain listed as open because their code was deliberately unchanged. Their independent dispositions remain applicable: hypothetical unsupported callers, optional diagnostics, optional disconnected-case refinement, and a duplicate. There is no unresolved fix-now or stop-for-decision item. The bounded replacement review is now running against the same head. |
Final local certification and review receipt
The draft is being marked ready now. The earlier skipped draft check is not certification evidence; merge requires a successful post-ready |
Summary
CI range selection and consumer-floor checks were maintained in two places, and scheduled deep checks repeated preflight's core command sequence. This change gives each behavior one owner while preserving the callers' different failure/comparison policies and independent jobs.
Add 20 real-Git regression cases and a maintenance inventory for action pins, lint configuration, and inherited release/coverage settings. External consumers remain unconfirmed, so inherited config is retained.
Closes #133.
Validation
task checkpasses on Go 1.27.1 (go.moddeclares 1.27; validation pin is 1.27.1).Current approved contract
Outcome: give repeated validation behavior one owner and make remaining configuration ownership explicit in one implementation PR. The user approved this plan on 2026-09-15.
Acceptance criteria (verbatim from issue #133)
Implementation and preservation requirements
Boundary, representation, and artifacts
Approved blast radius: validation scripts and their focused tests, Task orchestration, local composite actions, their deep/release workflow callers, Dependabot directory coverage, and maintenance documentation. Existing required ci.yml jobs, guards, permissions, triggers, tool versions, release tags, Go runtime code, dependencies, secret-scanning policy, and historical fingerprints are preserved.
The supported domain is the current CI environment interface and the named real-Git fixture cases. Git owns refs/history/diff representation; Go owns module parsing; Task and actionlint own their configuration semantics. The guarantee is example-level regression coverage, not exhaustive Git, Bash, YAML, or external-protocol conformance. Contract closure is not triggered: ordinary focused cases adequately bound the accepted refactor. No general scanner, workflow-to-Task validator, syntax enumeration, mutation campaign, timing/stress expansion, or platform cross-product is authorized.
Scripts, actions, Task targets, and tests are maintained verification aids. Their approved payoff is consistent validation across existing entrypoints; repository maintainers own them and retire helpers/tests when callers disappear or authoritative tooling replaces them. The range suite is approved as part of workflow-check, without a new required CI job. Inventory, contracts, and receipts are process metadata. No shipped runtime behavior or new required safety enforcement is introduced.
Finite evidence and review budget
Evidence: the 20 before/after shell cases; ShellCheck and Bash syntax; workflow validation; parsed composite manifests with explicit run shells; equality of named action-pin groups; Task execution-plan comparison; task check under the consumer Go floor; affected targets including release-gate; final task preflight at the exact pushed SHA under the validation Go pin; successful post-ready hosted required CI on that head. Go 1.27.1 currently satisfies both floor major/minor 1.27 and validation pin.
One fully briefed initial RAS review, accepted fix-now findings independently judged and verified, and at most one replacement review. Review findings are evidence, not authority. Adjacent issues, stronger unsupported input guarantees, and speculative evidence infrastructure are defer/reject rather than silently expanding scope. Stop for a boundary expansion, inability to preserve accepted behavior within this PR, or a second distinct semantic counterexample at the same precise invariant and enforcement owner. Chronology and receipts belong in PR comments rather than the normative contract.
After review and certification: make the draft ready, require successful ci-required and ci workflow on the certified head, and squash-merge that exact head. If main advances, update and repeat the prescribed gates. Only after product merge, complete the journal workflow, revalidate deferred findings against the merged code, and complete OmniFocus task pbItPLAkLXQ.