6/8 Use the published VPRM W_scale for every class - #43
Open
Timothy-W-Hilton wants to merge 1 commit into
Open
Conversation
Apply Mahadevan et al. (2008) Eq. 8, (1 + LSWI) / (1 + max_LSWI), for every land-cover class. The replaced equation can blow up toward +/- infinity if LSWI, min_lswi, and/or max_lswi are close to one another. This can happen in places with a small annual cycle. Add regression coverage for a nearly constant LSWI case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the published VPRM W_scale for every class
Summary
Use the W_scale formulation from Mahadevan et al. (2008), Eq. 8, for all VPRM land-cover classes:
Problem
vprm_base_model.get_w_scale()previously used a different expression for classes 4 and 7:That denominator can become extremely small where the annual LSWI range is small (i.e. max_LSWI and min_LSWI are close to one another), producing very large or non-finite W_scale values. This happened frequently in grassland and shrubland cells during New Zealand runs.
Change
land_cover_typein the method signature for API compatibility.Validation
tests/test_w_scale.py: 1 passed
full discovered test suite on this branch: 1 passed