Skip to content

Drop image options explanation popover #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tfuxu merged 1 commit into from
Nov 22, 2025
Merged

Drop image options explanation popover #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions data/ui/image_options_view.blp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,6 @@ template $HalftoneImageOptionsView : Adw.Bin {
Adw.PreferencesGroup options_group {
title: _("Options");

[header-suffix]
Gtk.MenuButton options_explanation_button {
valign: center;
popover: options_explanation_popover;
icon-name: "help-about-symbolic";
tooltip-text: _("Explanation");

styles [
"flat"
]
}

Adw.ComboRow dither_algorithms_combo {
title: _("Dither Algorithm");
model: Gtk.StringList algorithms_stringlist {
Expand All @@ -55,6 +43,18 @@ template $HalftoneImageOptionsView : Adw.Bin {
Adw.ComboRow export_format_combo {
title: _("Convert To");
model: Gtk.StringList image_formats_stringlist {};

[suffix]
Gtk.MenuButton convert_to_explanation_button {
valign: center;
popover: convert_to_explanation_popover;
icon-name: "help-about-symbolic";
tooltip-text: _("Explanation");

styles [
"flat"
]
}
}
}

Expand Down Expand Up @@ -137,10 +137,9 @@ template $HalftoneImageOptionsView : Adw.Bin {
};
}

Gtk.Popover options_explanation_popover {
Gtk.Label options_explanation_label {
Gtk.Popover aspect_ratio_explanation_popover {
Gtk.Label aspect_ratio_explanation_label {
max-width-chars: 30;
use-markup: true;
justify: center;
wrap: true;

Expand All @@ -149,12 +148,12 @@ Gtk.Popover options_explanation_popover {
margin-start: 6;
margin-end: 6;

label: _("To learn more about individual options, go to the <a href=\"https://github.com/tfuxu/Halftone/wiki/Options\">wiki page</a>.");
label: _("This option allows you to preserve original aspect ratio when resizing an image.");
}
}

Gtk.Popover aspect_ratio_explanation_popover {
Gtk.Label aspect_ratio_explanation_label {
Gtk.Popover convert_to_explanation_popover {
Gtk.Label convert_to_explanation_label {
max-width-chars: 30;
justify: center;
wrap: true;
Expand All @@ -164,6 +163,6 @@ Gtk.Popover aspect_ratio_explanation_popover {
margin-start: 6;
margin-end: 6;

label: _("This option allows you to preserve original aspect ratio when resizing an image.");
label: _("Useful if the original image was saved as JPEG, because dithered images tend to increase in size when saved in JPEG, rather than formats that use lossless or hybrid compression techniques.");
}
}