string: handle empty replace pattern - #141
Merged
Merged
Conversation
An empty search pattern never advances either strstr loop. Treat it as a successful no-op, matching the existing no-match behavior. Confidence: high Scope-risk: narrow Tested: official sc_str CMake test with ASan; GCC 13 ASan/UBSan; MinGW GCC 8 Not-tested: MSVC
tezc
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sc_str_replace()passes an empty search pattern tostrstr(). Since the pattern length is zero, neither replacement loop advances: the same-size path repeats indefinitely, while the resizing path repeats until the size guard rejects it.Treat an empty search pattern as a successful no-op, consistent with the existing no-match behavior. Add coverage for both empty-to-nonempty and empty-to-empty replacements.
Tests:
sc_str_testwith AddressSanitizer-Wall -Wextra -pedantic -Werrorand ASan/UBSan