[codex] support custom Agent executable locations#12
Open
ryan-wong-coder wants to merge 1 commit into
Open
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add user-configurable executable locations for every external Agent runtime. Preferences exposes a custom-location checkbox and native folder picker for Codex, Claude Code, Hermes, Gemini CLI, and OpenClaw. The selected location is persisted, resolved to the platform-specific executable, and shared by runtime status checks and process launch paths.
This version is rebuilt on the rewritten 1.0.6
mainhistory and integrates with the new shared CLI resolver plus the extracted Claude and Codex binary modules.Why
Desktop applications do not reliably inherit the user's shell
PATH, and Agents may be installed through version managers, application bundles, portable directories, or other non-standard locations. Users need a persistent way to point Flowix at the actual executable without creating symlinks.Closes #5.
Supersedes #6, which was closed when the upstream
mainhistory was rewritten.How tested
npx vitest run app/flowix-web/features/preferences/store/user-settings-store.test.ts— 13 tests passednpm run buildcargo check --manifest-path app/Cargo.toml -p flowix-desktopcargo test --manifest-path app/Cargo.toml -p flowix-desktop external_runtime::binary::tests— 2 tests passedcargo test --manifest-path app/Cargo.toml -p flowix-desktop external_runtime::cli_resolver::tests— 2 tests passedgit diff --checkcargo clippy --workspace -- -D warnings— the upstream tree currently contains baseline warnings outside this featureRisks
Checklist
.envfiles touchedmain