-
Notifications
You must be signed in to change notification settings - Fork 11
Skip planning on error and not-found pages #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1b8fb30
Skip planning on error and not-found pages
915c2b4
Drop the error-page inference from empty planner output
cee2855
Merge branch 'main' into fix/skip-planning-on-error-pages
DavertMik 32c559e
Treat an empty plan as a skip, not a planning failure
3ff46b3
Merge remote-tracking branch 'origin/main' into fix/skip-planning-on-…
64ad7e7
Check the plan for tests instead of throwing on an empty one
30a1730
Merge remote-tracking branch 'origin/main' into fix/skip-planning-on-…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plan() still throws when scenarios is empty and there is no current plan. So this turns the intended skip into a planning error. Should an empty list be handled as a valid skip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworked in 64ad7e7 — the earlier
EmptyPlanErroris gone. An empty scenario list is a value, not an exception:plan()returns the plan it built andrunAllStyleschecksplan.tests.length === 0, which means nothing to test here, so it stops trying further planning styles and the loop picks the next sub-page candidate. An empty plan is not pushed into the saved plans either.Expanding an existing plan is unchanged, and a genuine planning failure still retries as before.