fix: retry and surface check-run creation so required checks post#194
Merged
Conversation
createCheckRun made a single octokit.rest.checks.create call with no retry and no logging, so under concurrent jobs it could fail/drop for some jobs and silently leave a required check unposted, blocking the PR forever. - Retry checks.create with jittered backoff on 429/5xx/rate-limit/network errors; still fail fast on permission 403, 404, 422. - Log a success line (id + conclusion) so the outcome is visible. - On exhausted retries escalate to core.error + a job-summary note, while still never calling setFailed (exit 0 preserved).
Contributor
Contributor
🔬 TestGlance✅ 745 passed across 1 job — 100.0% · ⏱️ 3.3s
🟡 test — details✅ 745 passed
vs
Updated 2026-07-06T19:43:39.513Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createCheckRunmade a singleoctokit.rest.checks.createcall with no retry and no logging, so under concurrent test jobs it could fail or be dropped for some jobs and silently leave a requiredcheck-namecheck run unposted, blocking the PR forever with no signal. This makes check-run posting resilient and observable while still never failing the consumer's CI.Changes
checks.createwith jittered exponential backoff (honoringretry-after) on transient429/5xx/ rate-limit-403/ network errors; still fail fast on permission403,404,422.Created check run "<name>" (id=…, conclusion=…)) so the outcome is finally visible.core.errorplus a job-summary note — while still never callingsetFailed(exit 0 preserved). Documented the single deliberatecore.errorexception in.agents/observability.md.Test plan
pnpm test(745 passing, incl. new retry / rate-limit / exhausted-retry / success-log / never-setFailed cases)pnpm typecheck,pnpm lint,pnpm format:check,pnpm build