fix: promote silent analytics failures from debug to warning (#162)#191
Merged
Conversation
Analytics/history computation failures were logged via core.debug(), invisible unless the consumer enables Actions step debug logging, so a dropped delta / flaky / perf / trends section or lost run history looked like a clean run. Promote the six analytics catch blocks and the cache-hit-but-missing-file case to core.warning() with a "section skipped" clarifier. "Not enough runs yet" notices and verbose tracing stay at core.debug(). Still never setFailed, always exit 0 (FR5). Docs and known-issue E updated to reflect the resolution.
…ce-changes # Conflicts: # .agents/known-issues.md
…ce-changes # Conflicts: # .agents/known-issues.md
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analytics/history computation failures were logged via
core.debug(), invisible unless the consumer enables Actions step debug logging, so a dropped delta / flaky / perf / trends section (or lost run history) looked like a clean run. This promotes those data-affecting failures tocore.warning()so they are visible on a normal run, while keeping "not enough runs yet" notices and verbose tracing atcore.debug(). Resolves #162.Changes
src/index.ts: the six analyticscatchblocks (delta, tests-changed, flaky, perf, trends, base-branch) now warn with a "… section skipped." clarifier instead of debug-logging.src/history/actions-cache-storage.ts: cache-hit-but-missing-history-file now warns ("run history unavailable this run.") instead of silently returning null at debug level.warning, and added a cache-hit-but-missing-file test; allsetFailed-never-called guarantees preserved.observability.md/history-analytics.mdto the new logging convention.Test plan
pnpm typecheck,pnpm lint,pnpm format:checkcleanpnpm test— 738 passed (includes new/updated warning assertions and setFailed-never-called checks)pnpm buildbundles (dist/ not committed; CI rebuilds on main)core.setFailed(), always exit 0