chore: Defer Docker endpoint resolution until the client is built - #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR specifically addresses an issue related to Testcontainers. Testcontainers includes its own Docker endpoint discovery mechanism. As we have started moving this functionality into Docker.DotNet, where it ultimately belongs, applications that use both Docker.DotNet and Testcontainers may end up running similar endpoint discovery logic twice.
To reduce this overhead, this PR defers Docker.DotNet's endpoint resolution so that libraries implementing their own discovery mechanism are prioritized. This avoids unnecessary duplicate resolution while the migration is still in progress.
Once all endpoint discovery functionality has been consolidated into Docker.DotNet, this workaround can be removed.