Repository navigation
fix: import gen_batch and write under the repo tree - #1
Open
Chessing234 wants to merge 3 commits into
Open
Chessing234 wants to merge 3 commits into
Chessing234 wants to merge 3 commits into
Conversation
gen_all_batches imported a nonexistent mk_batch module and hardcoded a machine-local Windows path, so the regenerator could not run.
Author
|
could someone with write access approve the lean action ci run on this fork pr? it's stuck on action_required. |
Same hardcoded Windows path bug as gen_all_batches: generate into Sendov/... relative to the script instead of c:/Users/teort/...
Author
|
also fixed the same hardcoded path in gen_cover/gen_endgame/gen_sinh. |
PR tip put `from pathlib import Path` inside Lean templates for Endgame and Sinh, and still ran emit_batch cwd-relative. Move Path to the Python module scope, resolve sinh_tail beside the script, and invoke emit_batch via SCRIPTS paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/gen_all_batches.pyimported nonexistentmk_batch(ModuleNotFoundError)gen_batchand write underSendov/FiniteRangerelative to the repo rootTest plan
ls scripts/hasgen_batch.py, nomk_batch.pygen_batch.buildexistsMade with Cursor