Repository navigation
Classify RationalFunction2 degrees in descending coefficient order - #248
Open
chessing234 wants to merge 1 commit into
Open
chessing234 wants to merge 1 commit into
chessing234 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RationalFunction2 stores polynomial coefficients in descending order, but its degree predicates inspect them as ascending coefficients. This classifies x as constant, x² as affine, and 1/x as constant, and prints the wrong value for constants with leading zeros.
Inspect the coefficients preceding the constant or linear terms, and read the constant value from the final coefficient. Three new regression tests fail on main; all four tests pass with the fix alongside test_rationalfunction.py.