Repository navigation
Fix RationalFunction subtraction operator dispatch - #245
Open
chessing234 wants to merge 1 commit into
Open
chessing234 wants to merge 1 commit into
chessing234 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RationalFunction.__sub__callsself.sub, but the implemented method is namedsubtract. Consequentlyf - graisesAttributeErrorfor rational functions and numeric operands. Dispatch tosubtractand register a regression covering rational-function, integer, and fractional operands plus self-subtraction.Validation: the new regression fails on current upstream
c8eda5e4f1f51024b6cbf70c7bef6c33da74c691with the missing-method error. The patched full Python test runner (python tests/test_all.py) passes.