push: add --novis flag (skip visualize_samples on evaluate)#247
Merged
Conversation
When the user passes `leap push -e --novis` (or `-u … --novis`) the CLI
sets `EvaluateExistingVersionParams.noVisualization = true` on the
evaluate request. Engine then marks the visualize_samples step SKIPPED
instead of executing it — faster turnaround for headless evaluations
that don't need the dashboard's sample-level visualizations.
- validate that --novis requires --eval / --update (otherwise the
flag is a no-op and we error so the misuse is loud)
- thread through pushInputs → evalDispatch → RunEvaluate
- only meaningful on the RunEvaluate path; --update path that runs
update-evaluate-artifact has no visualize_samples step, so we
don't carry the flag there
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
--novisflag toleap push. When used alongside--eval(or-u, which implies--eval), the CLI sendsnoVisualization: trueon the evaluate request. The engine then marks thevisualize_samplesstepSKIPPEDinstead of running it.Why
Headless evaluations (CI, sweeps, debugging) often don't need the dashboard's per-sample visualizations. Skipping the step shortens the wall-clock and reduces visualization-artifact storage churn.
UX
```
evaluate without visualizations
leap push -e --novis
overwrite + update + skip vis
leap push -o my-model -u metric --novis
```
Misuse is loud:
--noviswithout--evalerrors at validate time.Code changes
cmd/root_cmd/push.gopushInputs.noVisualization+--novisflag bindingvalidatePushInputsrejects--noviswithout--eval/-uevalDispatch(only set on theRunEvaluatepath —update_evaluate_artifacthas no visualize step)pkg/model/evaluate.goRunEvaluatenow takesnoVisualization booland sets it onEvaluateExistingVersionParamswhen truePaired PRs
Test plan
go build ./...cleango vet ./...cleanleap push -e --novis→ engine marksvisualize_samplesSKIPPED, version still completesleap push --novis(no-e) → errors with clear messageleap push -e(no--novis) → identical behavior to today🤖 Generated with Claude Code