fix: correct misleading xdc-redirection note in workflow delete warning#1082
Closed
jiechenz wants to merge 1 commit into
Closed
fix: correct misleading xdc-redirection note in workflow delete warning#1082jiechenz wants to merge 1 commit into
jiechenz wants to merge 1 commit into
Conversation
The workflow delete warning (added in #1029) advised specifying `--grpc-meta xdc-redirection=false` to "target the passive cluster directly." For a global Namespace, delete is a mutating operation that must be served by the active cluster, so disabling redirection makes the passive cluster reject the request: failed starting batch operation: Namespace is active in cluster-a, while current cluster cluster-b is a standby cluster. The flag therefore can't produce a passive-only delete; it only turns a forwarded success into a local failure. The forwarding behavior is also generic XDC semantics, not delete-specific, so it doesn't belong pinned to this one command. Trim the warning (both the runtime message and the command help) to the accurate, delete-specific point: deletion in a global Namespace removes the Execution from all clusters and is irreversible. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Trims the
temporal workflow deletewarning (added in #1029) — both the runtime message and the command help text — to:The previous wording was removed:
Why?
The removed sentence was misleading in the one command where it was placed:
workflow deletecalls the frontendDeleteWorkflowExecution, a mutating op. For a global Namespace it must be served by the active cluster.Setting
--grpc-meta xdc-redirection=falsedisables forwarding, so a passive cluster has nowhere to send the request and rejects it:So the flag can't produce a "passive-only" delete — it only converts a forwarded success into a local failure. The forwarding/redirection behavior is also generic XDC semantics, not delete-specific, so it doesn't belong pinned to this single command's help. That concept is better documented on docs.temporal.io.
The kept sentence captures the genuinely delete-specific, accurate point: the blast radius (all clusters) and irreversibility.
Checklist
Closes
How was this tested:
make genregeneratedcommands.gen.go(no morexdc-redirectionreferences) and:Existing delete tests updated to assert against the new warning substring.
The active/standby request-forwarding (
xdc-redirection) behavior would be better explained in the multi-cluster section of docs.temporal.io rather than in CLI help.🤖 Generated with Claude Code