Fix/Validate Dispute Votes - #1061
Merged
Merged
Conversation
…choice and then also when counting vote power we do not let everything but against and support being counted as invalid
…s and make it more simple
danflo27
enabled auto-merge (squash)
August 21, 2026 14:13
danflo27
disabled auto-merge
August 21, 2026 14:13
danflo27
approved these changes
Aug 21, 2026
danflo27
added a commit
that referenced
this pull request
Aug 21, 2026
* made it so that it validates the vote choice to ensure it is a valid choice and then also when counting vote power we do not let everything but against and support being counted as invalid * addressed a vote accounting bug * strengthened testing around edge case dispute voting * refactored logic with voting on disputes. Tried to cleanup the changes and make it more simple * extended the new voting logic and safeguards to the SetTeamVote function * fixed test that was failing * made lint fixes * lint fix --------- (cherry picked from commit 50d81a1) Co-authored-by: CJPotter10 <91627020+CJPotter10@users.noreply.github.com> Co-authored-by: Dan F <florentinodc@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate Vote option to ensure that it is a valid enum option and when updating vote power we do not attribute all bug votes as invalid. Also fixed a bug where if a non reporter selector voted more than once on a dispute that it would continue to subtract the reporter vote power more than it needs to
Related Issue
Fixes #
Type of Change
Testing
all existing dispute tests
Checklist