Clean up test runtimes and protect Blaxel worker lifecycles

packages/web/test/e2e/browser-demo-mode.test.ts

@@ -6,6 +6,7 @@ import os from "node:os";
 import path from "node:path";
 import { test, expect } from "../../../../test/helpers/playwright.ts";
 import { launchProductServer, type ProductServer } from "../../../../test/helpers/product-server.ts";
+import { recordApplicationRequests } from "../../../../test/helpers/application-requests.ts";
 import { APPLICATION_SHELL_STATES, waitForApplicationRender } from "../../../../test/helpers/application-readiness.ts";
 import { configureTestMotion, pickChannelByName } from "./helpers.ts";
 
@@ -72,11 +73,10 @@ async function createURLArtifact(
   return ((await response.json()) as { artifact: { id: string } }).artifact.id;
 }
 
-async function openApp(page: Page, server: ProductServer, baseURL: string | undefined): Promise<void> {
-  if (!baseURL) throw new Error("Expected Playwright baseURL");
-  const appBaseURL = await server.appURL(baseURL);
-  await page.goto(`${appBaseURL}/packages/web/src/index.html`);
+async function openApp(page: Page, server: ProductServer, requests: ReturnType<typeof recordApplicationRequests>): Promise<void> {
+  await page.goto(server.serverURL);
   await waitForApp(page);
+  requests.expectBuilt();
 }
 
 async function waitForApp(page: Page): Promise<void> {
@@ -106,8 +106,10 @@ test.describe("browser demo mode", () => {
   let home: string;
   let site: Awaited<ReturnType<typeof startExternalSite>>;
   let server: ProductServer | null = null;
+  let requests: ReturnType<typeof recordApplicationRequests>;
 
-  test.beforeEach(async () => {
+  test.beforeEach(async ({ page }) => {
+    requests = recordApplicationRequests([page]);
     home = mkdtempSync(path.join(os.tmpdir(), "television-demo-home-"));
     site = await startExternalSite();
     server = await launchProductServer({
@@ -117,22 +119,23 @@ test.describe("browser demo mode", () => {
   });
 
   test.afterEach(async () => {
+    await requests.attach(test.info());
     await server?.dispose();
     server = null;
     await site.close();
     rmSync(home, { recursive: true, force: true });
   });
 
   // spec: proofs/product/artifacts.md#^af-ac-demo-mode
-  test("the home-directory marker turns direct external pages on and off at app load (^af-ac-demo-mode)", async ({ page, baseURL }) => {
+  test("the home-directory marker turns direct external pages on and off at app load (^af-ac-demo-mode)", async ({ page }) => {
     if (!server) throw new Error("Product server was not started");
     const [channel] = await channels(server);
     if (!channel) throw new Error("Expected a default channel");
     const pageURL = `${site.origin}/one`;
     await createURLArtifact(server, pageURL, channel.id);
     const returnButton = page.getByRole("button", { name: RETURN_LABEL });
 
-    await openApp(page, server, baseURL);
+    await openApp(page, server, requests);
     await expect(artifactFrame(page)).toHaveAttribute("src", /\/views\/url-unsupported\//);
     await expect(returnButton).toHaveCount(0);
 
@@ -152,15 +155,15 @@ test.describe("browser demo mode", () => {
   });
 
   // spec: proofs/product/artifacts.md#^af-ac-demo-return
-  test("the artifact icon, an app reload, and a channel round trip each return to the original page (^af-ac-demo-return)", async ({ page, baseURL }) => {
+  test("the artifact icon, an app reload, and a channel round trip each return to the original page (^af-ac-demo-return)", async ({ page }) => {
     if (!server) throw new Error("Product server was not started");
     writeFileSync(path.join(home, MARKER), "");
     const [channel] = await channels(server);
     if (!channel) throw new Error("Expected a default channel");
     await createChannel(server, "Elsewhere");
     await createURLArtifact(server, `${site.origin}/one`, channel.id);
 
-    await openApp(page, server, baseURL);
+    await openApp(page, server, requests);
     await expect(frameHeading(page)).toHaveText("Fixture page one");
 
     await followNext(page);
@@ -181,7 +184,7 @@ test.describe("browser demo mode", () => {
   });
 
   // spec: proofs/arch/artifact-frame/artifact-bridge.md#^ab-ac-demo-inert-seam
-  test("bridge-shaped messages from a demo-mode page change nothing (^ab-ac-demo-inert-seam)", async ({ page, baseURL }) => {
+  test("bridge-shaped messages from a demo-mode page change nothing (^ab-ac-demo-inert-seam)", async ({ page }) => {
     if (!server) throw new Error("Product server was not started");
     writeFileSync(path.join(home, MARKER), "");
     const [channel] = await channels(server);
@@ -191,7 +194,7 @@ test.describe("browser demo mode", () => {
     await createURLArtifact(server, pageURL, channel.id);
     await createURLArtifact(server, `${site.origin}/two`, channel.id, "Second page");
 
-    await openApp(page, server, baseURL);
+    await openApp(page, server, requests);
     const selected = page.getByRole("option", { name: channel.name, exact: true });
     await expect(selected).toHaveAttribute("aria-selected", "true");
     const tabs = page.locator(".top-bar .tab");

packages/web/test/e2e/gate-boot-barrier.spec.ts

@@ -1,4 +1,5 @@
-import { expect, test, type Page } from "@playwright/test";
+import { type Page } from "@playwright/test";
+import { expect, test } from "../../../../test/helpers/playwright.ts";
 import { mkdtempSync, rmSync } from "node:fs";
 import os from "node:os";
 import path from "node:path";

packages/web/test/e2e/theme-product-acceptance.test.ts

@@ -13,6 +13,8 @@ import { TelevisionClient } from "@telepath-computer/television-shared";
 import { test, expect } from "../../../../test/helpers/playwright.ts";
 import { launchProductServer, type ProductServer } from "../../../../test/helpers/product-server.ts";
 import { seedThemePackage } from "../../../../test/helpers/theme-package.ts";
+import { recordApplicationRequests } from "../../../../test/helpers/application-requests.ts";
+import { startStableFrontProxy } from "../../../../test/helpers/stable-front-proxy.ts";
 import { waitForApplicationShell } from "./helpers.ts";
 import {
   APPLICATION_SHELL_STATES,
@@ -611,12 +613,12 @@ test("Firefox refreshes a ready Markdown editor from a fixed-dark theme to light
 // proofs/arch/themes/delivery.md#^theme-delivery-t-active-package-refresh
 test("theme settings persist rendered app and artifact outcomes through a built-server restart", async ({
   browser,
-  baseURL,
 }) => {
-  if (!baseURL) throw new Error("Expected Playwright baseURL");
   const context = await browser.newContext({ colorScheme: null });
   const page = await context.newPage();
+  const requests = recordApplicationRequests([page]);
   const product = await launchProductServer();
+  const front = await startStableFrontProxy(product.serverURL);
   try {
     const themeAPath = seedThemePackage(
       product.home,
@@ -691,9 +693,10 @@ test("theme settings persist rendered app and artifact outcomes through a built-
       "https://example.com/appearance",
     );
 
-    const appURL = await product.appURL(baseURL);
-    await page.goto(`${appURL}/packages/web/src/index.html`);
+    const appURL = front.url;
+    await page.goto(appURL);
     await waitForApplicationShell(page);
+    requests.expectBuilt();
 
     await openSettings(page);
     await page.getByRole("button", { name: "Refresh themes" }).click();
@@ -843,6 +846,7 @@ test("theme settings persist rendered app and artifact outcomes through a built-
     )).toHaveCount(0);
 
     await product.restart();
+    front.setTarget(product.serverURL);
     await waitForApplicationShell(page);
     await expectAppearance("dark", FIXED_DARK);
     const persistedDisplay = await fetch(new URL("/display", product.serverURL));
@@ -868,6 +872,8 @@ test("theme settings persist rendered app and artifact outcomes through a built-
     expect((await expectSandboxFrame(page, "overlay")).instance)
       .not.toBe(beforeAdaptiveOverlay.instance);
   } finally {
+    await requests.attach(test.info());
+    await front.dispose();
     await product.dispose();
     await context.close();
   }
@@ -880,7 +886,6 @@ test("theme settings persist rendered app and artifact outcomes through a built-
 // proofs/arch/themes/delivery.md#^theme-delivery-t-frame-appearance-browser
 test("executable themes run only in the Chromium application lifecycle and isolate failures", async ({
   page,
-  baseURL,
   browserName,
 }) => {
   test.skip(browserName !== "chromium", "Chromium owns executable-theme browser acceptance");
@@ -890,11 +895,12 @@ test("executable themes run only in the Chromium application lifecycle and isola
   const reconnectBackoffBudget = 30_000;
   const themeResetNavigationBudget = 30_000;
   test.setTimeout(test.info().timeout + reconnectBackoffBudget + 2 * themeResetNavigationBudget);
-  if (!baseURL) throw new Error("Expected Playwright baseURL");
 
   const product = await launchProductServer();
+  const front = await startStableFrontProxy(product.serverURL);
   const secondPage = await page.context().newPage();
   const applicationPages = [page, secondPage] as const;
+  const requests = recordApplicationRequests(applicationPages);
   const selectReloadingTheme = async (value: string): Promise<void> => {
     // A consented script is cleared by replacing both application documents.
     // Observe that navigation before applying ordinary post-render assertions.
@@ -1062,13 +1068,14 @@ document.querySelector("#artifact-probe").addEventListener("click", () => {
       "Executable Theme Artifact",
       artifactPath,
     );
-    const appURL = await product.appURL(baseURL);
+    const appURL = front.url;
     await Promise.all(applicationPages.map(async (applicationPage) => {
       await applicationPage.goto(
-        `${appURL}/packages/web/src/index.html`,
+        appURL,
       );
       await waitForApplicationShell(applicationPage);
     }));
+    requests.expectBuilt();
     await openSettings(page);
     await page.getByRole("button", { name: "Refresh themes" }).click();
     const themeSelect = page.locator('tv-select[name="theme"]');
@@ -1783,6 +1790,7 @@ document.querySelector("#artifact-probe").addEventListener("click", () => {
     await expectExecutableRuns(applicationPages, 3);
 
     await product.restart();
+    front.setTarget(product.serverURL);
     // Allow one capped retry interval plus the usual 5s shell-ready budget.
     await Promise.all(applicationPages.map((applicationPage) =>
       waitForApplicationRender(
@@ -1845,6 +1853,8 @@ document.querySelector("#artifact-probe").addEventListener("click", () => {
     expect(scriptRequests.length).toBeGreaterThan(0);
     expect(scriptRequests.every((owner) => owner === "application")).toBe(true);
   } finally {
+    await requests.attach(test.info());
+    await front.dispose();
     await product.dispose();
     await secondPage.close();
   }

packages/web/test/e2e/update-journey.spec.ts

@@ -1,4 +1,5 @@
-import { expect, test, type Page } from "@playwright/test";
+import { type Page } from "@playwright/test";
+import { expect, test } from "../../../../test/helpers/playwright.ts";
 import { mkdtempSync, rmSync } from "node:fs";
 import os from "node:os";
 import path from "node:path";

packages/web/test/e2e/update-notification.01.spec.ts

@@ -1,4 +1,5 @@
-import { expect, test, type Locator, type Page } from "@playwright/test";
+import { type Locator, type Page } from "@playwright/test";
+import { expect, test } from "../../../../test/helpers/playwright.ts";
 import { mkdtempSync, rmSync } from "node:fs";
 import os from "node:os";
 import path from "node:path";

packages/web/test/e2e/update-notification.02.spec.ts

@@ -1,4 +1,5 @@
-import { expect, test, type Page } from "@playwright/test";
+import { type Page } from "@playwright/test";
+import { expect, test } from "../../../../test/helpers/playwright.ts";
 import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
 import os from "node:os";
 import path from "node:path";

packages/web/test/e2e/update-reload.spec.ts

@@ -1,4 +1,5 @@
-import { expect, test, type Page } from "@playwright/test";
+import { type Page } from "@playwright/test";
+import { expect, test } from "../../../../test/helpers/playwright.ts";
 import { mkdtempSync, rmSync } from "node:fs";
 import os from "node:os";
 import path from "node:path";

packages/web/test/foundation-copy.test.ts

@@ -1,6 +1,7 @@
 import { globSync, readFileSync, statSync } from "node:fs";
 import path from "node:path";
-import { describe, expect, test } from "vitest";
+import { describe, expect } from "vitest";
+import { test } from "../../../test/helpers/vitest.ts";
 import { enumerateTrackedPaths } from "../../../scripts/test/file-inventory.mjs";
 import { buildVersionedWebBundle } from "../../../test/helpers/versioned-web-bundle.ts";
 import {