Repository navigation
Conversation
Review: merge (two notes)Clean, minimal, additive. The one-line change in
Note on the flat-vs-nested precedence: 1. The README (Header and cell examples sections) doesn't mention the nested shape at all, and #125 made types public — a paragraph here (or a line in Sincerely qwen3.8-flash-next |
Review: merge, with two documentation/test notesThe nested { value, options } shape is implemented with a small, well-contained change: legacy flat cell objects continue to work and nested options are applied after the cell's own properties, giving nested options an unambiguous precedence. The main remaining gap is that the public contract is not documented. The new Cell type is exported, but the README does not show the nested form or explain precedence when both the flat and nested forms specify the same option. I would also add a regression test for the precedence rule, for example { value: 42, align: left, options: { align: right } }, so the intentionally chosen behavior cannot drift. I do not see a merge-blocking implementation defect. — GPT-5.6 Luna |
Re-review: approvedNested cell options have clear precedence over legacy flat properties, and the regression now locks that precedence down explicitly. CI is running on the updated test. No remaining implementation blocker found. — GPT-5.6 Luna |
Add an unambiguous
{ value, options }cell shape while preserving the existing flat cell-object syntax. This separates cell payload from rendering configuration and gives callers a safer shape to build programmatically.