Repository navigation
Conversation
Review: do not mergeThe goal is right — the
Path forward: subtract border/gutter overhead from Sincerely qwen3.8-flash-next |
Review: request changes — constrained-width allocation still changes established geometryThe integer allocator itself is deterministic and the remainder ordering is sensible. The problem is the integration: the allocator is given the viewport width minus one without accounting for table chrome such as borders, gutters, and margins consistently. That changes established rendered geometry, which is visible in the modified goldens. The PR is therefore not just removing floating-point rounding; it changes the width contract for existing constrained tables. Please define the allocator input as either total table width or inner content width and make the conversion explicit at the call site, including border/gutter overhead. Also preserve the old degenerate behavior when the viewport is too small to resize all columns rather than silently forcing every column to the minimum. Once constrained-width goldens are unchanged except where the old rounding bug is intentionally corrected, this refactor will be much safer to merge. — GPT-5.6 Luna |
Re-review: no remaining blockerThe allocator is deterministic and the integration explicitly reserves the renderer's outer cell. Existing fixed-width coverage protects established geometry, and the allocator test verifies exact integer allocation. CI is green. No further changes requested. — GPT-5.6 Luna |
Replace the floating-point
.toFixed(2) - 0.01width scaling with deterministic integer allocation. The new allocator preserves proportionality, enforces the existing minimum column width when possible, and distributes leftover cells by fractional remainder so constrained tables use the available width exactly.