Repository navigation
parse_functions: find functions inside FROM-clause subqueries, joins and table-function arguments - #2
Closed
asubbarao wants to merge 1 commit into
Conversation
asubbarao
force-pushed
the
fix/function-names-in-from-subquery
branch
from
September 23, 2026 18:44
d91d69d to
d7baad5
Compare
Author
|
Wrong repository: the parser_tools community extension is built from hotdata-dev/duckdb_extension_parser_tools. The same fix, ported to that repo's current code, is hotdata-dev#17. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_function_names/parse_functionsonly walk the SELECT list, WHERE, GROUP BY, HAVING and CTEs. Anything in the FROM clause is skipped:This walks
from_table(subqueries, both sides and the condition of a join, table-function arguments) and scalar subqueries in expressions, following the sameTableReferenceTypepatternparse_tables.cppalready uses.FROM (SELECT avg(n) …) s[][avg]FROM (SELECT upper(x) …) a JOIN (SELECT lower(y) …) b[][upper, lower]FROM range(abs(-5))[][abs]SELECT (SELECT sum(1)) WHERE x IN (SELECT length(z) …)[][sum, length]Tests added to both
parse_function_names.testandparse_functions.test; full suite passes (289 assertions in 8 test cases).🤖 Generated with Claude Code