fix for gcc16 in libflap + minor improvement in meson build system - #182
Merged
Conversation
MaxMignolet
commented
Jul 16, 2026
MaxMignolet
commented
Contributor
- Fix for the libflap in order to compile with gcc16, see szaghi/FLAP@806e069
- Improvement for the detection of linear algebra libraries in the Meson build system
small fix for meson build, it was unnecessarily looking for a lapack implementation when openblas was found (which already provides a lapack implementation)
mjv500
self-requested a review
August 17, 2026 10:04
mjv500
approved these changes
Aug 17, 2026
mjv500
left a comment
mjv500
left a comment
Contributor
There was a problem hiding this comment.
a bit ugly that the 2 changes (lib flap and meson) are mixed, but no big deal.
Both look clean. Waiting for autotests
I have merged the latest trunk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.