Skip to content

ci(macos): read the signing identity from the keychain #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tcpreplay-dev wants to merge 1 commit into from
Closed

ci(macos): read the signing identity from the keychain #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions .github/workflows/_build-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,35 +235,41 @@ jobs:

security find-identity -v -p codesigning "$KEYCHAIN_PATH"

SIGN_IDENTITY=$(security find-identity -v -p codesigning "$KEYCHAIN_PATH" \
| sed -n 's/^[[:space:]]*1)[[:space:]]*[0-9A-F]*[[:space:]]*"\(.*\)"$/\1/p')
if [ -z "$SIGN_IDENTITY" ]; then
echo "ERROR: no codesigning identity found in the imported keychain"
exit 1
fi
echo "Signing identity: $SIGN_IDENTITY"
echo "SIGN_IDENTITY=$SIGN_IDENTITY" >> $GITHUB_ENV

- name: Sign Application
env:
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
run: |
APP_BUNDLE="build/QK4.app"

echo "=== Signing frameworks and libraries ==="
find "$APP_BUNDLE/Contents/Frameworks" -name "*.dylib" -exec \
codesign --force --options runtime --sign "Developer ID Application: Michael Richard Garcia ($APPLE_TEAM_ID)" {} \;
codesign --force --options runtime --sign "$SIGN_IDENTITY" {} \;

find "$APP_BUNDLE/Contents/Frameworks" -name "*.framework" -exec \
codesign --force --options runtime --sign "Developer ID Application: Michael Richard Garcia ($APPLE_TEAM_ID)" {} \;
codesign --force --options runtime --sign "$SIGN_IDENTITY" {} \;

echo "=== Signing PlugIns ==="
find "$APP_BUNDLE/Contents/PlugIns" -name "*.dylib" -exec \
codesign --force --options runtime --sign "Developer ID Application: Michael Richard Garcia ($APPLE_TEAM_ID)" {} \;
codesign --force --options runtime --sign "$SIGN_IDENTITY" {} \;

echo "=== Signing main application with entitlements ==="
codesign --force --options runtime \
--entitlements "resources/QK4.entitlements" \
--sign "Developer ID Application: Michael Richard Garcia ($APPLE_TEAM_ID)" \
--sign "$SIGN_IDENTITY" \
"$APP_BUNDLE"

codesign --verify --verbose=2 "$APP_BUNDLE"
spctl --assess --type execute --verbose "$APP_BUNDLE" || echo "Note: spctl may fail before notarization"

- name: Create and Notarize DMG
env:
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
APPLE_API_ISSUER_ID: ${{ secrets.APPLE_API_ISSUER_ID }}
APPLE_API_KEY_BASE64: ${{ secrets.APPLE_API_KEY_BASE64 }}
Expand Down Expand Up @@ -295,7 +301,7 @@ jobs:
test -f "QK4-unsigned.dmg" || { echo "DMG creation failed after 3 attempts"; exit 1; }

echo "=== Signing DMG ==="
codesign --force --sign "Developer ID Application: Michael Richard Garcia ($APPLE_TEAM_ID)" \
codesign --force --sign "$SIGN_IDENTITY" \
"QK4-unsigned.dmg"
mv "QK4-unsigned.dmg" "$DMG_NAME"

Expand Down