fix: reject empty decoder resource selectors - #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Mac run showed that unset shell variables expand to
--item-id "". The previous CLI treated that as no selector and proceeded into an uncontrolled Favorites phase, producing only a genericBLOCKreport.This change validates
--item-idbefore repository tests, source health, or live phases begin. Empty and whitespace-only values now exit with an actionable argparse error; valid IDs and omitted selectors retain their existing behavior.Verification
--item-id ""on maina858488152f1e57453c7ad98ad9c620a69dda40784 passed, 0 failedpython3 tests/run_all.py:OVERALL: PASS (all suites green)1e9b23a663c8e5d6c5153bf0968e410d6273c5d2f2a9ec0877b678aa0eaa3ed99d68128f8c82de5fc21acefce1a52ce2978a9747Addresses #78