Fix select-mode header overlap/gap and Xcode 27 build crash - #263
Merged
taylorcox75 merged 1 commit intoSep 21, 2026
Merged
Conversation
Torrents screen (select mode): - Bulk actions bar no longer covers the last card (measured height fed back as list bottom padding instead of a fixed value) - Fixed the large gap above the first card after scrolling up, caused by a hardcoded header paddingTop sized for the full normal-mode header rather than select mode's shorter one (now measured) - Header (Select All / Close) no longer scrolls away or gets scrolled over by cards during selection — it's pinned as a normal in-flow sibling instead of an absolute overlay while selectMode is active, and FlatList now declares flex: 1 explicitly rather than relying on being the sole flex participant Connectivity log viewer: - Fixed the header overflowing/clipping the Clear button on narrower screens by making the Copy button icon-only (matching the existing debug-info copy button convention) and letting the title truncate Build: - Xcode 27 / iOS 27 SDK hard-fails app launch unless the generated native project adopts the UIScene life cycle. Added expo-build-properties with ios.enableSceneSupport, and updated withNativeTorrentFileCopy's AppDelegate.swift template match for the resulting shape change (the cold-launch .torrent-copy path is weaker under scene lifecycle - documented in the plugin, needs on-device verification) - Added npm run simulator, targeting a specific iOS 26.5 sim device Changelog: added the 3.8.45 entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expo-build-propertieswithios.enableSceneSupport, and updatedwithNativeTorrentFileCopy's AppDelegate template match for the resulting shape change. Addednpm run simulator.Known follow-up
The cold-launch
.torrent-copy race-condition fix is structurally weaker under scene lifecycle (documented inplugins/withNativeTorrentFileCopy.js) —factory.startReactNativeis no longer called from the patched method, so there's no longer a direct path to feed the copied URL into React's initial launch options. Needs on-device verification: cold-launch by tapping a.torrentin Files while the app isn't running.Test plan
npx tsc --noEmit: exit 0npm test: 80/80 suites, 1160/1160 tests passingnpm run lint: 0 errors, 38 warnings (baseline 37 + 1 pre-existing pattern already present elsewhere).torrentopen path noted above.🤖 Generated with Claude Code