Repository navigation
ci: rename the Demo rules workflow to Reference corpus - #536
Merged
Merged
Conversation
The demo command is gone. What these rules are now is the conformance corpus published as @taskless/cli/reference.json, and this job is the only place their fixtures execute. Rename the workflow, its job, the asset trees (demo-* -> reference-*), the manifest module (rules/demo -> rules/corpus) and the manifest script so the check says what it guards. No asset bytes change, so reference.json and the runtime rule's signature are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Demo rulescheck outlived thetaskless democommand (#87689c4), so its name no longer says what it guards. These rules are now the conformance corpus published as@taskless/cli/reference.json, and this workflow is the only place their fixtures execute:test/reference.test.tschecks the payload matches the asset trees, but never runs the rules. It stays as a smoke test, under a name that says so.Renamed
.github/workflows/demo-rule.yml→reference-corpus.yml, workflow and job namedReference corpuspackages/cli/assets/demo-{sg,vale,runtime}→reference-{sg,vale,runtime}src/rules/demo/manifest.ts→src/rules/corpus/manifest.ts,DEMO_MANIFESTS→CORPUS_MANIFESTS,DemoManifest→CorpusManifestdemo:manifests/print-demo-manifests.ts→corpus:manifests/print-corpus-manifests.tsUnchanged on purpose: every asset file's bytes, and so
reference.jsonand the runtime rule's signature. Asset directory names never appear in the payload; a regeneration produced no content diff. No changeset: nothing a consumer receives changes.Verified: typecheck, lint, the full CLI suite (2390 tests), and the workflow's own staging,
validateandverify --dangerously-run-scriptssteps replayed locally against the renamed paths: all three rules ran and passed.