Skip to content

docs: record that this stack-breadcrumb copy is the authoritative one - #224

Merged
theCodeDrift merged 1 commit into
mainfrom
docs/stack-breadcrumb-provenance
Aug 31, 2026
Merged

theCodeDrift merged 1 commit into
mainfrom
docs/stack-breadcrumb-provenance

Conversation

@theCodeDrift

Copy link
Copy Markdown
Member

Comment-only. Three files, 23 added lines, no behaviour change.

Why

The header said where the module came from and stopped there. That part is accurate — it did start as taskless/taskless's @taskless/stack-breadcrumb package. The fact a reader actually needs is the other one: this copy is now authoritative, and taskless/taskless vendors it rather than maintaining its own.

Without that, nothing here tells anyone that a change made in this file silently diverges a downstream copy, or that a fix made downstream is a fork the next sync discards.

The cloud team hit exactly that. Their CLAUDE.md credited the module to the wrong repository, and their copy's header claimed it had been "brought into this repository" from taskless/taskless — which is them, so the sentence had become self-referential once someone copied the header across. They corrected their end; this is ours.

It also records why there is no drift test

The obvious next question after "two copies exist" is "what checks they match". Nothing does, and that is deliberate — worth writing down before someone helpfully adds one.

This repository moves ahead of the vendored copy by design, so a drift test would fail on precisely the changes that are supposed to happen. The stakes fit that: a diverged breadcrumb renders a PR body slightly differently, where a diverged rule layout writes rules to the wrong place. That is why the layout table has a drift test and this has a sentence.

Worth noting the cloud team asked us to publish a ./stack-breadcrumb export so they could diff against it, then withdrew the request on their own reasoning: that shape is for peers who must not diverge, and this is not that. No export, nothing owed either way.

Scope

Applied to the module, its test, and the workflow — all three carry the same origin note, and a reader can arrive at any of them.

node --test on the module passes unchanged; house style clean.

The header said where the module came from and stopped there. Accurate: it
did start as taskless/taskless's `@taskless/stack-breadcrumb` package. But
the fact a reader needs is the other one — this copy is now authoritative,
and taskless/taskless vendors it rather than maintaining its own.

Without that, nothing here tells anyone that a change made in this file
silently diverges a downstream copy, or that a fix made downstream is a fork
the next sync discards. The cloud team hit exactly that: their CLAUDE.md
credited the module to the wrong repository, and their copy's header claimed
it had been "brought into this repository" from taskless/taskless — which is
them, so the sentence had become self-referential when someone copied the
header across. They corrected their end; this is ours.

Also records why there is no drift test, since the obvious next question
after "two copies exist" is "what checks they match". Nothing does, and
deliberately: this repository moves ahead of the vendored copy by design, so
a drift test would fail on precisely the changes that are supposed to
happen. The stakes fit — a diverged breadcrumb renders a PR body slightly
differently, where a diverged rule layout writes rules to the wrong place,
which is why that one has a drift test and this one has a sentence.

Applied to the module, its test, and the workflow, because all three carry
the same origin note and a reader can arrive at any of them.
@theCodeDrift

Copy link
Copy Markdown
Member Author

@claude /review

@claude

claude Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Claude finished @theCodeDrift's task in 1m 30s —— View job


Review complete

Review mode: incremental — read 0 prior review thread(s) before reviewing. .prior-review.json contains no reviewThreads, reviews, or comments beyond the @claude /review trigger itself, so this is the first review of this PR — nothing to carry forward as addressed or still-open.

  • Read .prior-review.json (empty — no prior findings)
  • Fetched diff via gh pr diff
  • Reviewed all three changed files, including surrounding unchanged context
  • Checked for correctness, consistency, and CLAUDE.md conventions issues

Findings

None. This is a comment-only change (23 added lines, 0 deletions, no logic touched) across .github/scripts/stack-breadcrumb.cjs, its test file, and .github/workflows/stack-breadcrumb.yml. I specifically checked:

  • Factual/internal consistency: the new note says this repo (taskless/cli) is authoritative and taskless/taskless vendors it, which doesn't contradict the pre-existing, untouched header ("Adapted from the taskless/taskless stack-breadcrumb implementation … brought into this repository") — the file originated upstream and this copy has since become authoritative, no self-reference problem like the one described in the PR body.
  • Consistency across the three files: all three carry equivalent wording, applied uniformly as the PR description claims.
  • Syntax/parse safety: the additions are plain // comments in the two .cjs files and # comments in the workflow YAML, placed before any executable/code content — no risk to node --test or YAML parsing.
  • Lint: no max-len rule in this repo's ESLint config, so the longer comment lines aren't a lint concern.
  • CLAUDE.md conventions: nothing in .conventions/STYLEGUIDE-CODE.md or the root CLAUDE.md bears on documentation-comment content; no violations found.

Nothing else in scope stood out — no inline comments to post.

@theCodeDrift

Copy link
Copy Markdown
Member Author

Re: @claude[bot] — "Findings None. This is a comment-only change…"
#224 (comment)

Thanks — nothing to action. Confirming the read: comment-only, no logic touched, and the three files carry the same origin note deliberately so a reader arriving at any of them finds the ownership direction.

— AI Coding Agent

@theCodeDrift
theCodeDrift merged commit 12318bd into main Aug 31, 2026
6 checks passed
@theCodeDrift
theCodeDrift deleted the docs/stack-breadcrumb-provenance branch August 31, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant