Repository navigation
chore: scrub comment punctuation and clarify a few whys - #2
Merged
Merged
Conversation
Add CLI scan/fail-on/cardinality/version tests, Materialize coverage, pattern/resolve edge cases, and a thin cmd/tarsier run() for testability.
Raise rules and cmd/tarsier packages to 100% statement coverage.
Replace em/en dashes and fancy arrows with ASCII. Extract packagesContainGo so the empty-Go success path is named instead of narrated. Trim finding status comments to the non-obvious bits. Co-authored-by: Bartłomiej Piekarz <Pieczasz@users.noreply.github.com>
Co-authored-by: Bartłomiej Piekarz <Pieczasz@users.noreply.github.com>
golangci-lint nolintlint failed CI on PR #2 after packagesContainGo extraction lowered cyclomatic complexity. Co-authored-by: Bartłomiej Piekarz <Pieczasz@users.noreply.github.com>
Drop the blank line left behind when the unused gocyclo directive was removed. Co-authored-by: Bartłomiej Piekarz <Pieczasz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-,->).packagesContainGoso the empty-Go success path is named instead of narrated.Test plan
go test ./engine/golang/ ./finding/ ./analyzers/otelresource/make ci(needs ast-grep on PATH in CI)