Create PR from fork - #1
webwarrior-ws wants to merge 41 commits into
Conversation
|
CI is broken |
5a98c87 to
82e1ec0
Compare
|
CI is still broken. @webwarrior-ws do you have github email notifications about this enabled? |
I've disabled notifications for CI failures because it's just noise in most cases. But I've seen that CI is still broken. It fails on "Upload coverage to Codecov". Perhaps authentication issue? I don't know what this Codecov service is. |
|
ok I thought it was still complaining about prettier format |
Let's create a PR upstream that changes that step to not be executed in forks. |
So can conventions' PR be merged now? |
Yes |
|
Ok done, but please rebase before testing |
82e1ec0 to
c738b24
Compare
|
It seems the experiment worked, so let's squash these commits and after that include the commit from PR2 as 1st commit of this one, to get green CI. |
92a9a7e to
6202e1e
Compare
Done. |
a8c21b8 to
52bf206
Compare
Let's add to this: "(especially in an environment where the repo to work with is public/open but direct commit access is not, while PRs are accepted from any github user account, regardless of the permissions of the latter)". After that, you can propose new PR upstream, with that single commit (not 2 commits). |
|
@webwarrior-ws Given that the maintainer merged already your first PR, you can actually remove that commit from here, rebase, and then propose the same commit that ends up here (same commit hash) in the new PR for upstream. Let's do this before or at EOD time, not Monday. Cheers |
…toe#412) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.37.9 to 4.38.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v4.37.9...v4.38.0) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.38.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
source: ecdcc5d branch: develop pi-sdk: 0.85.1
source: 936abc3 branch: develop pi-sdk: 0.85.1
## [2.28.1] - 2026-09-15 ### Changed - **deps-ci**: bump github/codeql-action from 4.37.9 to 4.38.0 (shaftoe#412) - **deps-dev**: bump vitest from 4.1.10 to 4.1.11 (shaftoe#410) ### Fixed - **opengist**: add default TTL for opengist uploads [2.28.1]: shaftoe/pi-coding-agent-action@v2.28.0...v2.28.1
Why was this not done? I still see the commit "GithubCI: don't run "Upload coverage to Codecov" step in forks" here |
52bf206 to
b07ed47
Compare
source: 1397590 branch: develop pi-sdk: 0.86.0
source: 1f47573 branch: develop pi-sdk: 0.87.0
## [2.29.0] - 2026-09-22 ### Added - add cache_warming input and summarize_text tool ### Changed - **deps**: bump Pi sdk to v0.87.0 ### Fixed - **README.md**: add checkout action to interactive workflow sample (shaftoe#414) - **deps**: bump Pi sdk to v0.86.0, remove obsolete patchSDKLoaderSource - ensure yaml is properly formatted [2.29.0]: shaftoe/pi-coding-agent-action@v2.28.1...v2.29.0
source: e87a919 branch: develop pi-sdk: 0.87.0
source: ab6dba7 branch: develop pi-sdk: 0.87.0
* test: remove obsolete AbortSignal.timeout fallback test AbortSignal.timeout exists since Node 17.3. The action runs on node24 and the Pi SDK requires Node >= 22.19, so the fallback case can't occur. * fix: refresh model catalog from pi.dev at startup Models released after the bundled Pi SDK (e.g. claude-opus-5-5) were "not found" until a new action release shipped a newer SDK. ModelRuntime.create() never downloads the catalog, and the SDK only downloads it for providers that have a credential. So refresh the configured provider's catalog after the API key is set. - Respects PI_OFFLINE (handled by the SDK). - Limited by MODEL_REFRESH_TIMEOUT_MS. - On failure, logs a warning and uses the built-in model list.
source: 19f3233 branch: develop pi-sdk: 0.87.0
source: 334c336 branch: develop pi-sdk: 0.87.0
source: 47a74de branch: develop pi-sdk: 0.87.0
source: 9a813ae branch: develop pi-sdk: 0.87.0
source: 473a22e branch: develop pi-sdk: 0.87.0
source: 9706e28 branch: develop pi-sdk: 0.87.1
## [2.29.1] - 2026-09-28 ### Changed - **deps**: bump Pi to v0.87.1 ### Fixed - add opt-out for model auto refresh - get_ci_status uses the current PR head by default (shaftoe#417) - refresh model catalog from pi.dev at startup (shaftoe#416) [2.29.1]: shaftoe/pi-coding-agent-action@v2.29.0...v2.29.1
If there are insufficient rights to push to the repository, agent will open a PR from a fork. This mirrors how human contributors work (especially in an environment where the repo to work with is public/open but direct commit access is not, while PRs are accepted from any github user account, regardless of the permissions of the latter).
And added tests for new functionality.
Rebuild dist/index.js.
Rebuild dist/index.js.
55c208d to
1aafd08
Compare
5 participants
If there are no permissions to push to the repository in question.