Skip to content

Modular pass 3/5: routed child questions #252

Closed

Description

@tannerpolley

Part of #24; follow the owner direction of 2026-10-28 there. This feature cost 126 conflict blocks.

Done means

  • The hunks for routing delegated children's questions and approvals to their parent move out of upstream-owned files into fork-owned modules behind small hooks. DelegatedRequestRouting.ts and DelegatedRequestWake.ts already exist; extend that seam.
  • No behavior change, and existing tests pass.
  • Before and after git merge-tree conflict counts against the latest nightly tag are in the PR body.

Out of scope: behavior changes.

Activity

  1. tannerpolley commented on Oct 30, 2026

    @tannerpolley
    OwnerAuthor

    T3 Code status: Done

    Issue: #252 Modular pass 3/5: routed child questions

    Thread: thread:delegated-task:command%3Amcp%3A7455bf35-e158-476a-9ad6-5ec3aa35bf20%3Adelegate-task%3Aissue24-pass3-252-implement-20261030

    Model: gpt-6.1-sol

    Branch: issue-252-modular-pass-3-5-routed-child-questions

    Updated: 2026-10-30T06:01:51.347Z

  2. tannerpolley commented on Oct 30, 2026

    @tannerpolley
    OwnerAuthor

    T3 Code closeout: done

    Issue: #252 Modular pass 3/5: routed child questions
    Thread: thread:delegated-task:command%3Amcp%3A7455bf35-e158-476a-9ad6-5ec3aa35bf20%3Adelegate-task%3Aissue24-pass3-252-implement-20261030
    Model: gpt-6.1-sol
    Branch: issue-252-modular-pass-3-5-routed-child-questions
    Completed: 2026-10-30T06:22:33.637Z

    Implemented #252 locally and committed as b539f4b7c33036acbd2407e49ac1c9f49efba4e6 (refactor(server): isolate delegated request routing policy).

    • Starting SHA: 7d9c2365a0b19075d5279091742c0504117e3bab
    • Branch: issue-252-modular-pass-3-5-routed-child-questions
    • Status: clean
    • No push, PR, merge, issue writes, subagents, live-data access, or server/UI launches.

    The extraction moves response validation and descendant authority into DelegatedRequestRouting.ts; routed wake handling and dispatch ordering into DelegatedRequestWake.ts; and relay alert settling into relay/DelegatedRequestAlerts.ts. The existing service, reactor, MCP, and relay paths retain small hooks. Contracts, persistence, client visibility policy, and provider adapters remain unchanged.

    Verification passed:

    Check Result
    agent-heavy vp run typecheck inside apps/server Exit 0, including committed candidate
    Six focused existing test suites Exit 0; 76 tests passed, including AgentContextBudget
    agent-heavy vp lint on all eight changed files Exit 0
    agent-heavy vp fmt --check on committed files Exit 0; explicitly reports all files correctly formatted
    Source equivalence comparisons Error messages, authority checks, response fields, MCP details, and relay settling logic match

    The final ordinary commit hook passed formatting and lint, then failed only on #256’s 74 existing unused exports. I used the explicitly authorized --no-verify bypass. The initial hook also found one export made internal by this extraction; I removed that export before retrying. Both attempts and the bypass log are preserved.

    The latest nightly discovered was v0.1.6-nightly.20261030.3904, SHA 36dac688a17c6de1c6398e62d01546fb787c185b. Using that identical SHA on both sides:

    Measurement Before After
    Conflicted paths 17 17
    <<<<<<< blocks in resulting conflicted blobs 23 23
    Changed-file intersection 1 path / 1 block 1 path / 1 block
    Broader inventoried routing-related paths 3 paths / 3 blocks 3 paths / 3 blocks

    Every per-file count is unchanged. No current-nightly reduction is claimed.

    Evidence is outside the tracked repository:

    Independent Checker review of this exact commit and delivery remain parent-owned. No implementation concerns remain from my checks; repo-wide checks and UI launches were excluded as instructed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions