Define sshx agent execution contract and close E2E quality gaps - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make test-shortandmake test-e2eworkflowsFixes
ssh.ServerAuthError, a server-side type that the real SSH client path does not returnImpact
Agents now have documented, test-enforced guarantees around target resolution, structured outcomes, authentication, trust, permissions, side effects, and recovery. Existing implemented top-level capabilities meet the acceptance floor; unimplemented multi-host execution and explainable governance remain explicitly marked as future work.
Validation
make checkgo test -short -race ./...make test-e2emake lintactionlint .github/workflows/ci.ymlmdbook buildgit diff --check