Conversation
Signed-off-by: Derek Kaser <11674153+dkaser@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the startup warning that labels
-use-local-tailscaledas development-only and advises against production use.The warning was initially added due to concerns that identity could be forged using XFF headers when tsidp was running in local-tailscaled mode. That concern was resolved via #179.
-use-local-tailscaledis beneficial for production environments because it allows for embedded installations of tsidp. For example, see https://github.com/dkaser/unraid-tsidp , which generates a local config file for tsidp, starts tsidp in local-tailscaled mode, and configures Unraid to use tsidp as an IdP. After installation, the only thing that a user has to do is add the authorized users to the Unraid configuration, and then they can log in with Tailscale.Using tsnet mode would increase user friction and create additional failure modes for embedded installations: