Repository navigation
portmap, cmd/gomodfs: make the static portmapper importable - #30
Merged
Merged
Conversation
The Windows NFS client always asks a portmapper on port 111 for the NFS and MOUNT ports, so serving gomodfs to Windows clients needs one. The static portmapper that does this lived in package main of cmd/gomodfs, so corp's CI, which runs gomodfs's NFS server inside cihostlet and needs to point Windows guests at it, would have had to copy it. Move it to a new portmap package with a Server type that answers GETPORT for the NFS, MOUNT, and NLM programs over TCP with a fixed port, serving on a caller-provided net.Listener and net.PacketConn so callers can choose addresses and filter clients. cmd/gomodfs's -portmapper flag uses it, with unchanged behavior on the wire. Along the way, TCP connections are now served concurrently instead of one at a time, and per-packet logging is optional. Updates tailscale/corp#24037 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows NFS client always asks a portmapper on port 111 for the NFS
and MOUNT ports, so serving gomodfs to Windows clients needs one. The
static portmapper that does this lived in package main of cmd/gomodfs,
so corp's CI, which runs gomodfs's NFS server inside cihostlet and
needs to point Windows guests at it, would have had to copy it.
Move it to a new portmap package with a Server type that answers
GETPORT for the NFS, MOUNT, and NLM programs over TCP with a fixed
port, serving on a caller-provided net.Listener and net.PacketConn so
callers can choose addresses and filter clients. cmd/gomodfs's
-portmapper flag uses it, with unchanged behavior on the wire.
Along the way, TCP connections are now served concurrently instead of
one at a time, and per-packet logging is optional.
Updates tailscale/corp#24037