Conversation
Keep candidate render artifacts in the candidate slot across S1 and S2. Preserve the trusted pinned renderer as a separate input. Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7468a3ce84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| manifest_closure="$(jq -er .closure "$candidate/candidate-manifest.json")" | ||
| [[ "$manifest_closure" == "$head_candidate" ]] || {{ echo "::error::candidate manifest closure $manifest_closure is not the head's candidate $head_candidate" >&2; exit 1; }} | ||
| echo "{VELNOR_WORKFLOW_PINNED_BINARY_ENV}=$candidate/velnor-workflow" >> "$GITHUB_ENV" | ||
| echo "{VELNOR_WORKFLOW_CANDIDATE_BINARY_ENV}=$candidate/velnor-workflow" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Because .github-gen/velnor-workflow.toml still selects the legacy e988 pin, repository generation executes this branch and now renders VELNOR_WORKFLOW_CANDIDATE_BINARY; however, the checked-in .github/workflows/ci-policy.yml:140 and ci-main.yml:242 still contain VELNOR_WORKFLOW_PINNED_BINARY. This makes checked_in_workflows_match_the_generator_byte_for_byte fail deterministically and leaves the intended acquisition change undeployed, so regenerate and commit the affected workflows with the renderer change.
AGENTS.md reference: crates/velnor-workflow/AGENTS.md:L19-L23
Useful? React with 👍 / 👎.
Keep generated CI workflows and generator ownership state aligned with the candidate runtime slot. Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
|
Closing without merge after branch review. The source branch duplicates the two-file patch already carried by this PR, and that patch changes |
1 participant
This is the single consolidation PR for the only live branch without an associated PR (
codex/candidate-binary-slot-20260927).The generator now sends a candidate runtime through
VELNOR_WORKFLOW_CANDIDATE_BINARYand keeps the trusted pinned renderer inVELNOR_WORKFLOW_PINNED_BINARYfor both S1 and S2. The generatedci-main.yml,ci-policy.yml, and ownership state are regenerated in this PR.Verification and required Policy checks are in progress. Do not merge unless the complete PR passes all required checks and the candidate-render workflow is independently reviewed.