fix(workflow): isolate Debian package outputs from cache state - #1101
Merged
Merged
Conversation
Clear cached package artifacts before each Debian packaging job so cargo-deb collects only the current architecture output. Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Use exact cargo-deb output roots and exercise stale cross-architecture packages in both collector roots. Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com> Co-authored-by: Codex <codex@openai.com>
…tput-isolation-20260923 Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com> Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com> Co-authored-by: Codex <codex@openai.com>
…tput-isolation-20260923 Signed-off-by: Codex <codex@openai.com>
Signed-off-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Keep candidate renderers in a dedicated environment slot so their manifest-verified artifact cannot shadow the declared pin. Preserve strict rejection for mismatched explicit pin binaries. Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Preserve candidate and pinned renderer separation. Bind candidate artifact execution to its manifest build revision and run candidate builds with a scrubbed environment. Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
Preserve the Rust capability scan/config outputs while carrying the Debian stale-output cleanup forward. Regenerated workflow outputs remain current for the merged candidate source. Co-authored-by: Codex <codex@openai.com> Signed-off-by: Alexey Zhokhov <alexey@zhokhov.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Preview arm64 packaging receives stale cache-restored Cargo workspace outputs. In run 35791295272,
target/debiancontained the old f7bc191 amd64 package beside the current 507e722 arm64 package. The collector intentionally reads onlytarget/debianand exacttarget/$TARGET/debian, then fails closed on distinct names.Fix
canonical=target/debianandtarget_root=target/$TARGET; notarget/*/debiantraversal.TARGETas one safe path component.target, canonical, exact target root/debian, anddistbefore deletion.find -Ponly at the three exact output roots, depth 1, deleting only regular-file or symlink.deb/.deb.sha256entries.Verification
Local:
cargo fmt --all -- --checkcargo test --locked -p velnor-workflow rendered_debian_reset: 4 passedcargo test --locked -p velnor-workflow debian_collect: 4 passedcargo test --locked -p velnor-workflow: 2737 passed--plain --check --pin-build: running locallyNormal merge ancestry:
6391a0ce53b7e666d1bfb391083011622158f4f3d5deb952676b4f22792a36b5fc89f29a068ee9ccDo not merge automatically.