Repository navigation
style: remove shadows from buttons and form controls - #587
Draft
ishigakijunichi wants to merge 1 commit into
Draft
ishigakijunichi wants to merge 1 commit into
ishigakijunichi wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ishigakijunichi
force-pushed
the
style/remove-control-shadows
branch
from
October 9, 2026 00:25
486f639 to
06393ae
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
shadow-xsfrom Buttonsecondaryand from the text-input style controls, so they sit flat.secondary: no shadow (default/destructiveare unchanged).controlBaseClasses(Input, Textarea,Field.Control, DateField input group): shadow removed in one place.Button
outline(its shadow and its fill) is handled in the companion PR #588. Not touched: Checkbox, Attachment, and the DataTable toolbar button groups still have their shadow.Why
secondary. It is a light-coloured button. A faint shadow on a pale fill blurs the outline of the UI and makes it look smudged rather than crisp.border-inputborder. Addingshadow-xson top doubles the edge and softens it, which is the same blur problem as above. In dark mode the shadow is barely visible, so the two themes also looked different.Cardkeeps itsshadow-xs) is the raised layer and the controls inside it are flat. Buttons and inputs placed side by side share the same flat treatment, and all the input-like components (including Select, Combobox and Autocomplete) match each other.Before / After
Screenshots are from the showcase app with the default theme.
button
Light
Dark
input
Light
Dark
textarea
Light
Dark
select
Light
Dark
combobox
Light
Dark
autocomplete
Light
Dark
Test plan
pnpm vitest runinpackages/core— snapshots updated; the only failures are the 17 pre-existingdata-tablelocalStorage tests, which fail identically onmainexamples/vite-appshowcase pages (/showcase/primitives,/showcase/dropdown) in light and dark