Skip to content

fix(minimax): MiniMax M3 model support#3434

Merged
amitksingh1490 merged 5 commits into
tailcallhq:mainfrom
ImBIOS:feat/add-minimax-m3-support
Jun 2, 2026
Merged

fix(minimax): MiniMax M3 model support#3434
amitksingh1490 merged 5 commits into
tailcallhq:mainfrom
ImBIOS:feat/add-minimax-m3-support

Conversation

@ImBIOS
Copy link
Copy Markdown
Contributor

@ImBIOS ImBIOS commented Jun 2, 2026

Summary

Add MiniMax M3 model support to forgecode, extending transformer logic and provider configuration to include M3 variants.

Context

Currently, forgecode supports MiniMax M2 series (MiniMax-M2.7) models but lacks M3 support. This feature request was created as issue #3433 after confirming there were no existing issues or PRs for MiniMax M3.

Changes

  • Extended SetMinimaxParams transformer to match minimax-m3 pattern in addition to existing M2 patterns
  • Added M3-specific default parameters: temperature 1.0, top_p 0.95, top_k 40 (same as M2.1)
  • Added MiniMax M3 models to provider.json:
    • minimax.minimax-m3 - Flagship model with 204800 context length
  • Added comprehensive tests for M3 variants, including case-insensitive matching

Key Implementation Details

The transformer now checks for both minimax-m2 and minimax-m3 patterns. M3 models use the same parameter optimization as M2.1 (top_k: 40) rather than the base M2 settings (top_k: 20).

Use Cases

  • Use minimax-m3 models for enhanced reasoning tasks
  • Automatic parameter optimization when using MiniMax M3 providers

Testing

cargo test --package forge_app minimax
# Expected: 13 tests passed (4 new tests for M3 support)

Links

Copilot AI review requested due to automatic review settings June 2, 2026 03:34
@github-actions github-actions Bot added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: provider Updates provider.json configuration. labels Jun 2, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds support for MiniMax M3 and M3 Pro models, including provider entries and parameter transformer logic with associated tests.

Changes:

  • Registers two new MiniMax M3 model entries in the provider catalog.
  • Extends SetMinimaxParams transformer to detect minimax-m3 and apply temperature/top_p/top_k defaults.
  • Adds three unit tests covering M3, case-insensitivity, and M3 Pro.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/forge_repo/src/provider/provider.json Adds minimax.minimax-m3 and minimax.minimax-m3-pro model definitions.
crates/forge_app/src/dto/openai/transformers/minimax.rs Updates transformer to match M3 variants, sets top_k=40, and adds tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Extended transformer to match minimax-m3 pattern
- Added M3 models (minimax-m3, minimax-m3-pro) to provider.json
- Added top_k: 40 for M3 models (same as M2.1)
- Added comprehensive tests for M3 variants

Co-Authored-By: ForgeCode <noreply@forgecode.dev>
@ImBIOS ImBIOS force-pushed the feat/add-minimax-m3-support branch from f8e084d to 6178b86 Compare June 2, 2026 03:40
Comment thread crates/forge_repo/src/provider/provider.json Outdated
Comment thread crates/forge_repo/src/provider/provider.json
Co-Authored-By: ForgeCode <noreply@forgecode.dev>
Comment thread crates/forge_app/src/dto/openai/transformers/minimax.rs Outdated
@amitksingh1490 amitksingh1490 changed the title feat: add MiniMax M3 model support fix(minimax): MiniMax M3 model support Jun 2, 2026
@amitksingh1490 amitksingh1490 added type: fix Iterations on existing features or infrastructure. and removed type: feature Brand new functionality, features, pages, workflows, endpoints, etc. labels Jun 2, 2026
ImBIOS and others added 2 commits June 2, 2026 10:48
- Context length: 1M (not 204K) - M3 uses MSA sparse attention
- Input modalities: text + image (natively multimodal)
- Description: frontier coding, 1M context, MSA, multimodality
- Added M3 to minimax direct provider (MiniMax-M3) and Bedrock
- Same transformer params as M2.7 (temp=1.0, top_p=0.95, top_k=20)
- Added bedrock provider ID test

Co-Authored-By: ForgeCode <noreply@forgecode.dev>
The bedrock provider already had minimax-m3 entry at line 1447.
Removed the duplicate with incorrect specs (context=204800 instead of 1M,
modalities=text instead of text+image).

Co-Authored-By: ForgeCode <noreply@forgecode.dev>
@ImBIOS
Copy link
Copy Markdown
Contributor Author

ImBIOS commented Jun 2, 2026

@amitksingh1490, all good now, sir?

@amitksingh1490 amitksingh1490 enabled auto-merge (squash) June 2, 2026 03:59
@amitksingh1490 amitksingh1490 merged commit c2437e9 into tailcallhq:main Jun 2, 2026
8 checks passed
@ImBIOS ImBIOS deleted the feat/add-minimax-m3-support branch June 2, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Iterations on existing features or infrastructure. type: provider Updates provider.json configuration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MiniMax M3 model support

3 participants