Repository navigation
fix: name sign-in walls and keep account-bound downloads in the browser - #4
Merged
Merged
Conversation
A download endpoint that names the file in ?filename= now counts as a file link, so an HTML sign-in answer is explained instead of recorded as a generic 400. A redirect that ends at accounts.google.com is named as a sign-in wall, the query filename becomes the row name, and catch why points at the browser session rather than suggesting a resume that can never authenticate.
Catch has no browser cookies, so taking over a Gemini, Docs, Drive, or Gmail download cancels the one request that can succeed and leaves a sign-in redirect. Let the browser keep these hosts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
filename=query parameter as a file URL, so an HTML sign-in answer to/download?filename=report.docxis explained instead of recorded as400 Bad Request.accounts.google.comas a sign-in wall.catch whynow points at the browser session instead of suggesting a resume that can never authenticate.filename=when the path has no extension, so the row and saved file keep their.docx/.zipname.Tests
cargo test -p catch— 63 unit + 42 reliability testscargo clippy -p catch --all-targets -- -D warningsnode --checkboth extension scripts;cmpconfirms they are identicalbin/check-release,bin/lint-qml,tests/install.test.shsign-in required — this link needs the browser's account session...and keeps its.docxfilename.Try it
Then retry an account-bound Google link (or
catch why <id>on the existing failed row). It should no longer say400 Bad Request; it should saysign-in requiredand tell you to download it with the browser. New Gemini/Docs/Drive/Gmail downloads will stay in the browser instead of being intercepted.