fix(server): pass MCP description via instructions, not version - #317
Open
syf2211 wants to merge 1 commit into
Open
fix(server): pass MCP description via instructions, not version#317syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
Server(self.name, self.description) mapped the description onto the version parameter in the MCP Python SDK. Use fastapi.version for serverInfo.version and self.description for instructions instead. Fixes tadata-org#272 Fixes tadata-org#293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix MCP server initialization so the FastApiMCP
descriptionis no longer passed as the MCP serverversion.Motivation
Server(self.name, self.description)passed the description as the second positional argument, which maps toversionin the MCP Python SDK. In MCP Inspector this showed up as the server "Version" field instead of server guidance text.Fixes #272
Fixes #293
Changes
Serverwithversion=self.fastapi.versionandinstructions=self.descriptiontest_create_mcp_serverTests
All 3 tests passed.
Notes
The current MCP Python SDK exposes server guidance via
instructionsinInitializeResult, not a separatedescriptionfield onServer.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.