Repository navigation
fix(model-bench): reject sessions without a final answer - #299
Merged
Merged
Conversation
enkerewpo
marked this pull request as ready for review
October 27, 2026 09:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cases without
expect.answeredcould pass after Pilot dispatched the expected calls even when the session ended without a final answer. Require a non-whitespace final answer, no reported Pilot failure, and no explicitfinished: falsein both the runner checks and the summary of saved results. Existing execution checks and judge verdicts remain unchanged.The saved dev regression for case 16 (
decomp.named_room) recordedpilot_failed: false,fails: [],final: "", andpass: true; its CLI session exited 1 without a final event. A snapshot of all 16 live board submissions contained 646 cases, including 10 passing cases with empty finals. The same completion gate rejects those cases without another model or judge call.Older result files lack
finished; their recorded nonempty final remains eligible. They do not retain CLI exit codes or error logs, so this fix cannot retrospectively identify every hidden Pilot error. Failed HTTP requests before a successful retry remain eligible.Validation: on work_pc,
python3 -m unittest discover -s testing -p test_model_bench.py -vpassed all 11 tests. Tests cover empty and whitespace finals, explicit unfinished sessions, reported failures, old files withoutfinished, existing call failures, and cached judge verdicts without new judge requests.git diff --checkpassed. No capability contracts, generated code, or configuration changes.