Repository navigation
Conversation
agicy
marked this pull request as ready for review
October 31, 2026 06:51
agicy
requested review from
HeartLinked,
enkerewpo and
ohhhHwH
as code owners
October 31, 2026 06:51
enkerewpo
reviewed
Nov 1, 2026
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class Catalog: |
Member
There was a problem hiding this comment.
Maybe ModelCatalog? Since we use catalog for capabilities before
Contributor
Author
There was a problem hiding this comment.
Got it. I'll rename it to ModelCatalog in both Python and Rust to avoid confusion with the capability catalog.
enkerewpo
reviewed
Nov 1, 2026
| "base_url": "http://127.0.0.1:8000/v1", | ||
| "model": "Qwen2.5-VL-7B-Instruct-AWQ", | ||
| "api_key_env": "VLLM_API_KEY", | ||
| "capabilities": { |
Member
There was a problem hiding this comment.
please don’t use capabilities here and also in other code structures, since we used it as our skill/service/primitive interface. Maybe use feature
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Robonix's model consumers each duplicate endpoint, model, key and feature assumptions. There is no single source of truth for what a model supports, so changing a model means editing every consumer and feature mismatches surface only at runtime.
User-visible impact
A deployment can set
ROBONIX_LLM_CATALOGto one YAML/JSON catalog. Each consumer resolves its endpoint from feature and budget requirements at startup, then connects to the provider directly. Without the variable every consumer keeps its existingVLM_*/manifest path; rollout is per service and rollback is unsetting the variable.Implementation
robonix_api.llminpylib/robonix-api; Rust:system/llm-catalog.ModelCatalog: validated YAML/JSONModelSpeclist (endpoint, model,api_key_env, features, context, p95 latency, prices, protocol);api_key_envis a variable name, never a key.(latency, price, id)→ best-firstModelSpec[].json_schemafalls back tojson_objectonly when no strict candidate fits and marks targetsdowngraded=true.ModelCatalog.load,ModelCatalog.model,ModelCatalog.resolve,Requirements.default,resolve_from_env,api_key_for.vision,tools,stream;ROBONIX_LLM_*overrides budgets.vision), Memory (json_object/vision), Memsearch (text), VLM Verifier (vision, covering the new before/after and multi-camera paths through the sharedVlmConfig.parse), and CI scripts. All keep the legacy path when the catalog is unset.Validation
PYTHONPATH=pylib/robonix-api python3 -m unittest discover -s pylib/robonix-api/tests -p 'test_llm_*.py'→ 18 passedrbnx codegen -p services/verifiers/vlm_verifier --mcpcargo test -p robonix-llm-catalog3 passed;cargo test -p robonix-pilot111 passed;cargo test -p robonix-cli36 passedVLM_*unset, onlyROBONIX_LLM_CATALOG+ provider key): rbnx preflight skipped, Pilot resolvedvlm=catalogcargo fmt --check,cargo clippy ... -D warnings,cargo metadata --locked,uv lock --check: cleanOK; exploration produced 41 objects / 75 relations; Pilot 2 requests, 22,281 input / 1,237 output, 81% cachered, blue; simulation shut down with no robonix containers and GPUs back to 1 MiBConfiguration and migration
ROBONIX_LLM_CATALOG— absolute catalog path; unset means legacy behavior.ROBONIX_LLM_FEATURES— Pilot's required model features; defaults tovision,tools,stream.api_key_env; Core never stores keys.uv.lockis unchanged.Related issues
None.
Screenshots / terminal output
No CLI, TUI or web UI changes.