[enkerewpo]

Summary

Full code review of the robonix codebase — fixes security vulnerabilities, bugs, CI failures, and adds 19 regression tests.

Commit 1: Security & Bug Fixes

Security (HIGH)

• Path traversal in builtin tools: read_file, write_file, patch_file, list_dir accepted arbitrary paths (e.g. ../../../etc/passwd). Added safe_resolve() to confine file access within workspace root (ROBONIX_WORKSPACE env or cwd).
• Command execution hardening: Added 8KB command length limit and 120s execution timeout to run_command.
• Shell injection in docker-entrypoint.sh: Unquoted heredoc <<EOF expanded env vars into ~/.bashrc — malicious env values could inject arbitrary shell commands. Changed to quoted <<'EOF'.
• Silent bad JSON in MCP dispatch: unwrap_or_default() masked invalid tool arguments. Now returns explicit error.

Bugs (MEDIUM-HIGH)

• truncate() UTF-8 panic: Slicing &s[..max] could split multi-byte chars (Chinese/emoji), panicking at runtime. Now uses floor_char_boundary().
• Spinner flush().unwrap() panics: 3 sites in CLI crashed if stdout was closed (piped to dead process). Changed to let _ = flush().
• Integer overflow in BufferSpec::frame_bytes()/stride(): width * height * channels * bpe with large u32 values silently wrapped. Now uses checked_mul().
• pyrightconfig.json: Trailing comma made file invalid JSON, breaking Pyright type checking.
• Null pointer dereference in rbnx_buffer.py: FFI header_ptr used without null check in open() and attach().
• File handle leaks in benchmark.py: json.load(open(...)) never closed file handles. Replaced with with context managers.

Commit 2: CI & Clippy Fixes

• Fix CI workflow: ci.yml referenced nonexistent make ci-rust / make ci-full targets. Replaced with actual steps (cargo fmt --check, cargo clippy, cargo build). Added dev to trigger branches.
• Fix all clippy warnings across entire workspace (collapsible_if, manual_flatten, too_many_arguments, should_implement_trait, wildcard_in_or_patterns, manual_contains, cloned_ref_to_slice_refs, lines_filter_map_ok, etc.)
• Fix all cargo fmt formatting issues.
• make check now passes cleanly with zero errors.

Commit 3: Systematic Regression Tests (19 tests)

Category	Tests	What's verified
Path traversal	5	../ rejected, absolute path outside workspace rejected, write blocked, read blocked, in-workspace allowed
Command hardening	2	>8KB command rejected, normal echo hello succeeds
UTF-8 truncation	3	ASCII, Chinese 3-byte, emoji 4-byte — no panic at mid-char boundary
Buffer overflow	4	u32::MAX overflow panics with message (not silent wrap), normal 1920x1080 correct
Buffer format/header	3	All 17 formats roundtrip, unknown returns None, header == 64 bytes
Misc	2	Unknown builtin errors, total_bytes includes header

Additionally validated externally:

• pyrightconfig.json parses as valid JSON
• Python files pass py_compile syntax check
• docker-entrypoint.sh passes bash -n syntax check + injection simulation test
• CI workflow YAML validates with correct structure and dev branch triggers

Test plan

• cargo test -p robonix-buffer -p robonix-executor — 19/19 passed
• make build — compiles successfully
• make check (fmt + clippy) — zero errors
• pyrightconfig.json — valid JSON
• Python syntax check — benchmark.py, rbnx_buffer.py pass
• Shell injection test — <<'EOF' prevents variable expansion
• CI workflow YAML — valid structure, includes dev branch

Note: 2 pre-existing robonix-atlas tests fail due to port binding in this environment (not related to this PR).

https://claude.ai/code/session_01RnU7NBm6mxcKqgTGox4jyh