Repository navigation
fix(build): move all back to the first target in Makefile - #404
Merged
Merged
Conversation
Contributor
Author
|
@dallasxy. Related finding from the same commit, left out here to keep this PR focused on the default goal:
Nothing here is blocked by it (GitHub Actions runs no CI checks on this PR; the equivalent check is Jenkins' |
dallasxy
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #403.
Restores
allas the default goal so a baremakebuilds hvisor again, and pins it in a way that target order can no longer change.alltarget back to the first position (directly under.PHONY) and add a one-line comment on why it must stay there. The recipe is moved verbatim; the comment and one blank line are the only new lines..DEFAULT_GOALexplicitly in the existingptestblock:allby default,ptestwhenmake ptest=<name>is given.clean_checktarget and its.PHONYentry. It has been dead code since the same commit that caused this regression:allnow depends onensure_configdirectly, and nothing else referenced the wrapper.Motivation
PR #319 added
kconfig_venv:/ensure_config:aboveall:, which silently changed the default goal fromalltokconfig_venv. A baremaketherefore stopped building hvisor and exited 0, breaking the commands documented in hvisor-book (make BID=aarch64/phytium-pi LOG=info,make ARCH=x86_64 BOARD=nuc14mnk,make BID=aarch64/rk3588). Fixing the target order alone would leave the same trap for the next target added aboveall, so the default goal is now declared explicitly instead of being an implicit side effect of file layout.The
ptestblock is written as a single exhaustive decision rather than relying on assignment order: a.DEFAULT_GOAL := allplaced after that block silently overridesmake ptest=..., which would be the same bug in a new place. Note that any non-emptyptestvalue selects that goal, so invalid names still fail inptest-checkas before.Verification (updated)
End-to-end build at the branch head (86f41fd) — a bare
make, exactly the command from the issue:Before this fix the same command stopped after the venv bootstrap.
Missing (not run): QEMU boot / functional regression. This change only affects which target a bare
makeselects; no compilation input, flag, or source file changes.Risks and Limitations
clean_checkdrops a (dead) user-visible target: invokingmake clean_checknow reports "No rule to make target". Nothing in the repo, CI, or documentation calls it, and its only action (ensure_config) is still a direct prerequisite ofall.