Repository navigation
Conversation
agicy
reviewed
Oct 10, 2026
agicy
left a comment
Contributor
There was a problem hiding this comment.
I suggest rebasing on upstream/dev instead of merging.
agicy
reviewed
Oct 10, 2026
| WARN_RE = re.compile(r"\[\s*WARN\b") | ||
| ERROR_RE = re.compile(r"\[\s*(ERROR|ERR|CRIT)\b") | ||
| PANIC_RE = re.compile( | ||
| r"\b(Kernel panic|panicked at|PANIC|Oops:|BUG:)\b", re.IGNORECASE |
Contributor
There was a problem hiding this comment.
- The
Oops:/BUG:alternatives can never match: the trailing\bafter:requires a word character to follow, but real messages have a space. Verified no-match forOops: 0002 [#1] SMPandBUG: unable to handle kernel NULL pointer dereference— i.e. kernel oopses/BUGs, exactly the failures this gate exists for, will not fail the job. - Conversely, the bare
PANICalternative matches any standalone occurrence of the word "panic" (verified:Kernel command line: ... panic=10, andmode-panic = <0x5242c307>— a DT property present in the rk3568 DT this PR re-enables). A healthy run can be failed by a DT/cmdline echo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two CI reliability improvements:
1.Unified zone1 console handling
Improve how the zone1 console is attached and driven so zone0 and zone1 use the same access path. This reduces flaky CI failures caused by unreliable zone1 serial/console input (for example screen/pty attach and Enter handling).
2.Post-run WARN / ERROR / panic log checks
Persist each BID’s console output to logs/__.log and add a Jenkins stage that scans it after tests. WARN lines are reported; ERROR/CRIT and panic markers fail the job.
Previously CI only checked functional case outcomes and could miss serious hvisor failures. A concrete example on aarch64/qemu-gicv3: zone1 was configured with CPUs 3,4, but QEMU only provides CPUs 0–3. That invalid mapping triggered an hvisor panic at runtime, yet CPU 3 still worked enough for zone1 cases to pass, so CI reported success. With console severity checking, such ERROR/panic lines are surfaced and the pipeline fails.
3.add a script jenkins/run_ci.sh to run ci locally